Skip to content

[PHP] fix numeric value in model enum#10474

Merged
wing328 merged 2 commits intomasterfrom
php-enum-name
Sep 28, 2021
Merged

[PHP] fix numeric value in model enum#10474
wing328 merged 2 commits intomasterfrom
php-enum-name

Conversation

@wing328
Copy link
Copy Markdown
Member

@wing328 wing328 commented Sep 26, 2021

  • fix numeric value in model enum by using the "NUMBER_" prefix

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

cc @jebentier (2017/07), @dkarlovi (2017/07), @mandrean (2017/08), @jfastnacht (2017/09), @ackintosh (2017/09) ❤️, @ybelenko (2018/07), @renepardon (2018/12)

@wing328 wing328 merged commit 1a50f1f into master Sep 28, 2021
@wing328 wing328 deleted the php-enum-name branch September 28, 2021 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant