Skip to content

Remove type erasure of the Error response, as it is always the same type#10460

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
vrwim:swift5-error-type-erasure
Sep 25, 2021
Merged

Remove type erasure of the Error response, as it is always the same type#10460
wing328 merged 1 commit intoOpenAPITools:masterfrom
vrwim:swift5-error-type-erasure

Conversation

@vrwim
Copy link
Copy Markdown

@vrwim vrwim commented Sep 23, 2021

Removed type erasure by specifying the error type, as it is always the same one. Simple fix, tested it with my local project.

cc: @jgavris @ehyche @Edubits @jaz-ah @4brunu

PR checklist

  • [x ] Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Copy link
Copy Markdown
Contributor

@4brunu 4brunu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for opening this PR.
This is a nice improvements.
Looks good to me 👍
CI issue doesn't seams to be related to this PR.

@wing328
Copy link
Copy Markdown
Member

wing328 commented Sep 23, 2021

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@vrwim
Copy link
Copy Markdown
Author

vrwim commented Sep 24, 2021

@wing328 I added the e-mail address I use for git locally to my Github account (I thought I did this once before). Now it shows my account on the commit of this branch, I hope that's enough.

@wing328 wing328 merged commit 4e029e9 into OpenAPITools:master Sep 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants