Skip to content

[Java] Add semicolon as a special case#10451

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
msmerc:patch-1
Sep 23, 2021
Merged

[Java] Add semicolon as a special case#10451
wing328 merged 1 commit intoOpenAPITools:masterfrom
msmerc:patch-1

Conversation

@msmerc
Copy link
Copy Markdown
Contributor

@msmerc msmerc commented Sep 22, 2021

Please could you also add ; as a special case in enums?

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Please could you also add `;` as a special case in enums?
@msmerc msmerc changed the title Add semicolon as a special case [Java] Add semicolon as a special case Sep 22, 2021
@msmerc
Copy link
Copy Markdown
Contributor Author

msmerc commented Sep 22, 2021

@bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608 @nmuesch

The ruberick says to mention you - how can I get this simple fix in?

@wing328
Copy link
Copy Markdown
Member

wing328 commented Sep 22, 2021

cc @OpenAPITools/generator-core-team as the change covers default codegen

@wing328
Copy link
Copy Markdown
Member

wing328 commented Sep 23, 2021

Thanks for the PR, which looks good to me.

@wing328 wing328 merged commit 916791d into OpenAPITools:master Sep 23, 2021
@wing328 wing328 added this to the 5.3.0 milestone Sep 23, 2021
@msmerc msmerc deleted the patch-1 branch September 23, 2021 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants