[Typescript] Improve exception for unknown responses#10361
Merged
macjohnny merged 9 commits intoOpenAPITools:masterfrom Sep 24, 2021
bodograumann:fix-typescript-unknown-response-body
Merged
[Typescript] Improve exception for unknown responses#10361macjohnny merged 9 commits intoOpenAPITools:masterfrom bodograumann:fix-typescript-unknown-response-body
macjohnny merged 9 commits intoOpenAPITools:masterfrom
bodograumann:fix-typescript-unknown-response-body
Conversation
agilob
reviewed
Sep 10, 2021
macjohnny
reviewed
Sep 14, 2021
Running the petstore server locally fixes all issues.
Contributor
Author
|
Rebased on master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For http errors that are not explicitly defined in the api specification, currently the consolidated typescript generator does not retain the body. Instead a generic
[object Object]string is provided for it in the error message. This is probably an oversight.Instead we now set the message string and response body attributes on the exception object separately.
Additionally I have added a heuristic which tries to parse the response as JSON, falls back first to plain text, then to binary and then to undefined.
I have added a new
deleteNonExistantPetintegration test to the default typescript/node petstore sample.This is a template-only change.
Steps:
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(5.3.0),6.0.xCC @TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02)