Skip to content

[R] Fix shellcheck violations in git_push.sh.template#10345

Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom
ahjota:aj/shellcheck-git-push
Sep 8, 2021
Merged

[R] Fix shellcheck violations in git_push.sh.template#10345
wing328 merged 2 commits intoOpenAPITools:masterfrom
ahjota:aj/shellcheck-git-push

Conversation

@ahjota
Copy link
Copy Markdown
Contributor

@ahjota ahjota commented Sep 7, 2021

To test:

openapi-generator generate --config bin/configs/r-client.yaml

To validate fix:

✗ which shellcheck
/usr/local/bin/shellcheck
✗ shellcheck samples/client/petstore/R/git_push.sh

#10343

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@ahjota ahjota changed the title Fix shellcheck violations in git_push.sh template for R [R] Fix shellcheck violations in git_push.sh.template Sep 7, 2021
@wing328 wing328 added this to the 5.3.0 milestone Sep 8, 2021
@wing328
Copy link
Copy Markdown
Member

wing328 commented Sep 8, 2021

LGTM. Thanks for the fix.

@wing328 wing328 merged commit 8576782 into OpenAPITools:master Sep 8, 2021
@wing328 wing328 mentioned this pull request Sep 9, 2021
5 tasks
@ahjota ahjota deleted the aj/shellcheck-git-push branch September 9, 2021 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants