Skip to content

Add ArchUnit to test format of loggers and Abstract classes#10335

Merged
wing328 merged 11 commits intoOpenAPITools:masterfrom
agilob:add-archunit-to-test-format-of-loggers
Sep 9, 2021
Merged

Add ArchUnit to test format of loggers and Abstract classes#10335
wing328 merged 11 commits intoOpenAPITools:masterfrom
agilob:add-archunit-to-test-format-of-loggers

Conversation

@agilob
Copy link
Copy Markdown
Contributor

@agilob agilob commented Sep 6, 2021

ArchUnit tests bytecode of Java code to make sure it follows correct rules.

Loggers will be enforced to be private/protect final not static to prevent loading them to memory on every program start.

Classes that have "abstract" in name have to be, in fact, abstract.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328

@wing328
Copy link
Copy Markdown
Member

wing328 commented Sep 9, 2021

LGTM. Thanks for the enhancement.

cc @OpenAPITools/generator-core-team

@wing328 wing328 added this to the 5.3.0 milestone Sep 9, 2021
@wing328 wing328 merged commit d2d06f0 into OpenAPITools:master Sep 9, 2021
@agilob agilob deleted the add-archunit-to-test-format-of-loggers branch September 9, 2021 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants