Skip to content

[csharp-netcore] verbose null checking#10333

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
aeneasr:close-dotnet-9442
Sep 8, 2021
Merged

[csharp-netcore] verbose null checking#10333
wing328 merged 1 commit intoOpenAPITools:masterfrom
aeneasr:close-dotnet-9442

Conversation

@aeneasr
Copy link
Copy Markdown
Contributor

@aeneasr aeneasr commented Sep 6, 2021

This patch addresses an issue where csharp-netcore failed to generate compilable code when required attributes were of complex types.

By using the non-shorthand syntax for checking if the value is set, and throwing an error in that case, the compile issues have been resolved.

Closes #9442
Closes #5442

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

This patch addresses an issue where csharp-netcore failed to generate compilable code when required attributes were of complex types.

By using the non-shorthand syntax for checking if the value is set, and throwing an error in that case, the compile issues have been resolved.

Closes OpenAPITools#9442
Closes OpenAPITools#5442
@aeneasr
Copy link
Copy Markdown
Contributor Author

aeneasr commented Sep 6, 2021

/cc @mandrean @frankyjuang @shibayan @Blackclaws @lucamazzanti

aeneasr added a commit to ory/sdk that referenced this pull request Sep 6, 2021
aeneasr added a commit to ory/sdk that referenced this pull request Sep 6, 2021
@wing328 wing328 added this to the 5.3.0 milestone Sep 8, 2021
@wing328
Copy link
Copy Markdown
Member

wing328 commented Sep 8, 2021

LGTM. Thanks for the PR.

@leus
Copy link
Copy Markdown

leus commented Oct 1, 2021

I'm currently using the latest release (5.2.1) which doesn't have this fix. How can I get it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] csharp-netcore generates invalid code [BUG] [csharp-netcore] Invalid expressions are generated using ??

3 participants