[csharp-netcore] verbose null checking#10333
Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom Sep 8, 2021
Merged
Conversation
This patch addresses an issue where csharp-netcore failed to generate compilable code when required attributes were of complex types. By using the non-shorthand syntax for checking if the value is set, and throwing an error in that case, the compile issues have been resolved. Closes OpenAPITools#9442 Closes OpenAPITools#5442
Contributor
Author
|
/cc @mandrean @frankyjuang @shibayan @Blackclaws @lucamazzanti |
6 tasks
aeneasr
added a commit
to ory/sdk
that referenced
this pull request
Sep 6, 2021
This is a workaround until OpenAPITools/openapi-generator#10333 is merged. Closes #103
5 tasks
aeneasr
added a commit
to ory/sdk
that referenced
this pull request
Sep 6, 2021
This is a workaround until OpenAPITools/openapi-generator#10333 is merged. Closes #103
Member
|
LGTM. Thanks for the PR. |
1 task
|
I'm currently using the latest release (5.2.1) which doesn't have this fix. How can I get it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch addresses an issue where csharp-netcore failed to generate compilable code when required attributes were of complex types.
By using the non-shorthand syntax for checking if the value is set, and throwing an error in that case, the compile issues have been resolved.
Closes #9442
Closes #5442
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(5.3.0),6.0.x