fix: 🐛 Added ability to override basePath while creating ApiClient instance#10327
Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom Sep 23, 2021
KillDozerX2:master
Merged
fix: 🐛 Added ability to override basePath while creating ApiClient instance#10327wing328 merged 1 commit intoOpenAPITools:masterfrom KillDozerX2:master
wing328 merged 1 commit intoOpenAPITools:masterfrom
KillDozerX2:master
Conversation
Member
|
Can you please follow step 3 in the PR checklist to update the samples? |
Contributor
Author
|
I'll run it again. |
Member
|
Tests with updated samples passed via https://app.circleci.com/pipelines/github/OpenAPITools/openapi-generator/12897/workflows/fda1123c-4fb8-4787-908a-7efe0384da95/jobs/26534 I'll update the samples after merging this PR. Thanks again for the contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #9179
Allows overwriting the basePath, this useful when the base url cannot always be known beforehand.
@CodeNinjai @frol @cliffano This is an update to only the ApiClient constructor
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(5.3.0),6.0.x