Skip to content

fix: 🐛 Added ability to override basePath while creating ApiClient instance#10327

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
KillDozerX2:master
Sep 23, 2021
Merged

fix: 🐛 Added ability to override basePath while creating ApiClient instance#10327
wing328 merged 1 commit intoOpenAPITools:masterfrom
KillDozerX2:master

Conversation

@KillDozerX2
Copy link
Copy Markdown
Contributor

@KillDozerX2 KillDozerX2 commented Sep 5, 2021

Solves #9179
Allows overwriting the basePath, this useful when the base url cannot always be known beforehand.
@CodeNinjai @frol @cliffano This is an update to only the ApiClient constructor

PR checklist

  • Read the contribution guidelines.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Copy Markdown
Member

wing328 commented Sep 15, 2021

Can you please follow step 3 in the PR checklist to update the samples?

@KillDozerX2
Copy link
Copy Markdown
Contributor Author

I'll run it again.

@wing328
Copy link
Copy Markdown
Member

wing328 commented Sep 23, 2021

Tests with updated samples passed via https://app.circleci.com/pipelines/github/OpenAPITools/openapi-generator/12897/workflows/fda1123c-4fb8-4787-908a-7efe0384da95/jobs/26534

I'll update the samples after merging this PR.

Thanks again for the contribution.

@wing328 wing328 merged commit 538f12c into OpenAPITools:master Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants