Skip to content

cpp-qt-client: Fix cppcheck warnings#10322

Merged
wing328 merged 3 commits intoOpenAPITools:masterfrom
MartinDelille:cppcheck-fix
Sep 8, 2021
Merged

cpp-qt-client: Fix cppcheck warnings#10322
wing328 merged 3 commits intoOpenAPITools:masterfrom
MartinDelille:cppcheck-fix

Conversation

@MartinDelille
Copy link
Copy Markdown
Contributor

@MartinDelille MartinDelille commented Sep 3, 2021

Here is a list of improvement to fix most of the cppcheck and clazy warning by a generated code:

The second commit improve the coding style.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples: 
    ./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@ravinikam @stkrwork @etherealjoy @muttleyxd

wing328
wing328 reviewed Sep 7, 2021
View reviewed changes
Comment thread modules/openapi-generator/src/main/resources/cpp-qt-client/api-body.mustache Outdated
@wing328 wing328 added Client: C++ Enhancement: Code format Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc. Enhancement: General labels Sep 8, 2021
@wing328 wing328 added this to the 5.3.0 milestone Sep 8, 2021
@wing328
Copy link
Copy Markdown
Member

wing328 commented Sep 8, 2021

LGTM but I've not tested it locally

@wing328 wing328 merged commit 2239ca3 into OpenAPITools:master Sep 8, 2021
@wing328
Copy link
Copy Markdown
Member

wing328 commented Sep 9, 2021

Looks like this breaks the build:

I/home/travis/build/OpenAPITools/openapi-generator/samples/client/petstore/cpp-qt/client -I/home/travis/build/OpenAPITools/openapi-generator/samples/client/petstore/cpp-qt/build/client/client_autogen/include -isystem /usr/include/x86_64-linux-gnu/qt5 -isystem /usr/include/x86_64-linux-gnu/qt5/QtCore -isystem /usr/lib/x86_64-linux-gnu/qt5/mkspecs/linux-g++-64 -isystem /usr/include/x86_64-linux-gnu/qt5/QtNetwork  -fPIC -Wall -Wno-unused-variable -fPIC -Wall -Wno-unused-variable   -fPIC -std=c++14 -o CMakeFiles/client.dir/PFXPetApi.cpp.o -c /home/travis/build/OpenAPITools/openapi-generator/samples/client/petstore/cpp-qt/client/PFXPetApi.cpp
/home/travis/build/OpenAPITools/openapi-generator/samples/client/petstore/cpp-qt/client/PFXPetApi.cpp: In member function ‘void test_namespace::PFXPetApi::setNewServerForAllOperations(const QUrl&, const QString&, const QMap<QString, test_namespace::PFXServerVariable>&)’:
/home/travis/build/OpenAPITools/openapi-generator/samples/client/petstore/cpp-qt/client/PFXPetApi.cpp:129:38: error: ‘class QMap<QString, int>’ has no member named ‘keyBegin’
     for (auto keyIt = _serverIndices.keyBegin(); keyIt != _serverIndices.keyEnd(); keyIt++) {
                                      ^
/home/travis/build/OpenAPITools/openapi-generator/samples/client/petstore/cpp-qt/client/PFXPetApi.cpp:129:74: error: ‘class QMap<QString, int>’ has no member named ‘keyEnd’
     for (auto keyIt = _serverIndices.keyBegin(); keyIt != _serverIndices.keyEnd(); keyIt++) {
                                                                          ^
/home/travis/build/OpenAPITools/openapi-generator/samples/client/petstore/cpp-qt/client/PFXPetApi.cpp: In member function ‘void test_namespace::PFXPetApi::addPet(const test_namespace::PFXPet&)’:
/home/travis/build/OpenAPITools/openapi-generator/samples/client/petstore/cpp-qt/client/PFXPetApi.cpp:236:44: error: ‘class QMap<QString, QString>’ has no member named ‘keyValueBegin’
     for (auto keyValueIt = _defaultHeaders.keyValueBegin(); keyValueIt != _defaultHeaders.keyValueEnd(); keyValueIt++) {
                                            ^
/home/travis/build/OpenAPITools/openapi-generator/samples/client/petstore/cpp-qt/client/PFXPetApi.cpp:236:91: error: ‘class QMap<QString, QString>’ has no member named ‘keyValueEnd’
     for (auto keyValueIt = _defaultHeaders.keyValueBegin(); keyValueIt != _defaultHeaders.keyValueEnd(); keyValueIt++) {
                                                                                           ^
/home/travis/build/OpenAPITools/openapi-generator/samples/client/petstore/cpp-qt/client/PFXPetApi.cpp: In member function ‘void test_namespace::PFXPetApi::deletePet(const qint64&, const test_namespace::OptionalParam<QString>&)’:
/home/travis/build/OpenAPITools/openapi-generator/samples/client/petstore/cpp-qt/client/PFXPetApi.cpp:298:44: error: ‘class QMap<QString, QString>’ has no member named ‘keyValueBegin’
     for (auto keyValueIt = _defaultHeaders.keyValueBegin(); keyValueIt != _defaultHeaders.keyValueEnd(); keyValueIt++) {
                                            ^
/home/travis/build/OpenAPITools/openapi-generator/samples/client/petstore/cpp-qt/client/PFXPetApi.cpp:298:91: error: ‘class QMap<QString, QString>’ has no member named ‘keyValueEnd’
     for (auto keyValueIt = _defaultHeaders.keyValueBegin(); keyValueIt != _defaultHeaders.keyValueEnd(); keyValueIt++) {
                                                                                           ^
/home/travis/build/OpenAPITools/openapi-generator/samples/client/petstore/cpp-qt/client/PFXPetApi.cpp: In member function ‘void test_namespace::PFXPetApi::findPetsByStatus(const QList<QString>&)’:
/home/travis/build/OpenAPITools/openapi-generator/samples/client/petstore/cpp-qt/client/PFXPetApi.cpp:426:44: error: ‘class QMap<QString, QString>’ has no member named ‘keyValueBegin’
     for (auto keyValueIt = _defaultHeaders.keyValueBegin(); keyValueIt != _defaultHeaders.keyValueEnd(); keyValueIt++) {
                                            ^
/home/travis/build/OpenAPITools/openapi-generator/samples/client/petstore/cpp-qt/client/PFXPetApi.cpp:426:91: error: ‘class QMap<QString, QString>’ has no member named ‘keyValueEnd’
     for (auto keyValueIt = _defaultHeaders.keyValueBegin(); keyValueIt != _defaultHeaders.keyValueEnd(); keyValueIt++) {
                                                                                           ^
/home/travis/build/OpenAPITools/openapi-generator/samples/client/petstore/cpp-qt/client/PFXPetApi.cpp: In member function ‘void test_namespace::PFXPetApi::findPetsByTags(const QList<QString>&)’:
/home/travis/build/OpenAPITools/openapi-generator/samples/client/petstore/cpp-qt/client/PFXPetApi.cpp:564:44: error: ‘class QMap<QString, QString>’ has no member named ‘keyValueBegin’
     for (auto keyValueIt = _defaultHeaders.keyValueBegin(); keyValueIt != _defaultHeaders.keyValueEnd(); keyValueIt++) {
                                            ^
/home/travis/build/OpenAPITools/openapi-generator/samples/client/petstore/cpp-qt/client/PFXPetApi.cpp:564:91: error: ‘class QMap<QString, QString>’ has no member named ‘keyValueEnd’
     for (auto keyValueIt = _defaultHeaders.keyValueBegin(); keyValueIt != _defaultHeaders.keyValueEnd(); keyValueIt++) {
                                                                                           ^
/home/travis/build/OpenAPITools/openapi-generator/samples/client/petstore/cpp-qt/client/PFXPetApi.cpp: In member function ‘void test_namespace::PFXPetApi::getPetById(const qint64&)’:
/home/travis/build/OpenAPITools/openapi-generator/samples/client/petstore/cpp-qt/client/PFXPetApi.cpp:634:44: error: ‘class QMap<QString, QString>’ has no member named ‘keyValueBegin’
     for (auto keyValueIt = _defaultHeaders.keyValueBegin(); keyValueIt != _defaultHeaders.keyValueEnd(); keyValueIt++) {
                                            ^
/home/travis/build/OpenAPITools/openapi-generator/samples/client/petstore/cpp-qt/client/PFXPetApi.cpp:634:91: error: ‘class QMap<QString, QString>’ has no member named ‘keyValueEnd’
     for (auto keyValueIt = _defaultHeaders.keyValueBegin(); keyValueIt != _defaultHeaders.keyValueEnd(); keyValueIt++) {
                                                                                           ^
/home/travis/build/OpenAPITools/openapi-generator/samples/client/petstore/cpp-qt/client/PFXPetApi.cpp: In member function ‘void test_namespace::PFXPetApi::updatePet(const test_namespace::PFXPet&)’:
/home/travis/build/OpenAPITools/openapi-generator/samples/client/petstore/cpp-qt/client/PFXPetApi.cpp:681:44: error: ‘class QMap<QString, QString>’ has no member named ‘keyValueBegin’
     for (auto keyValueIt = _defaultHeaders.keyValueBegin(); keyValueIt != _defaultHeaders.keyValueEnd(); keyValueIt++) {
                                            ^
/home/travis/build/OpenAPITools/openapi-generator/samples/client/petstore/cpp-qt/client/PFXPetApi.cpp:681:91: error: ‘class QMap<QString, QString>’ has no member named ‘keyValueEnd’
     for (auto keyValueIt = _defaultHeaders.keyValueBegin(); keyValueIt != _defaultHeaders.keyValueEnd(); keyValueIt++) {
                                                                                           ^
/home/travis/build/OpenAPITools/openapi-generator/samples/client/petstore/cpp-qt/client/PFXPetApi.cpp: In member function ‘void test_namespace::PFXPetApi::updatePetWithForm(const qint64&, const test_namespace::OptionalParam<QString>&, const test_namespace::OptionalParam<QString>&)’:
/home/travis/build/OpenAPITools/openapi-generator/samples/client/petstore/cpp-qt/client/PFXPetApi.cpp:745:44: error: ‘class QMap<QString, QString>’ has no member named ‘keyValueBegin’
     for (auto keyValueIt = _defaultHeaders.keyValueBegin(); keyValueIt != _defaultHeaders.keyValueEnd(); keyValueIt++) {
                                            ^
/home/travis/build/OpenAPITools/openapi-generator/samples/client/petstore/cpp-qt/client/PFXPetApi.cpp:745:91: error: ‘class QMap<QString, QString>’ has no member named ‘keyValueEnd’
     for (auto keyValueIt = _defaultHeaders.keyValueBegin(); keyValueIt != _defaultHeaders.keyValueEnd(); keyValueIt++) {
                                                                                           ^
/home/travis/build/OpenAPITools/openapi-generator/samples/client/petstore/cpp-qt/client/PFXPetApi.cpp: In member function ‘void test_namespace::PFXPetApi::uploadFile(const qint64&, const test_namespace::OptionalParam<QString>&, const test_namespace::OptionalParam<test_namespace::PFXHttpFileElement>&)’:
/home/travis/build/OpenAPITools/openapi-generator/samples/client/petstore/cpp-qt/client/PFXPetApi.cpp:809:44: error: ‘class QMap<QString, QString>’ has no member named ‘keyValueBegin’
     for (auto keyValueIt = _defaultHeaders.keyValueBegin(); keyValueIt != _defaultHeaders.keyValueEnd(); keyValueIt++) {
                                            ^
/home/travis/build/OpenAPITools/openapi-generator/samples/client/petstore/cpp-qt/client/PFXPetApi.cpp:809:91: error: ‘class QMap<QString, QString>’ has no member named ‘keyValueEnd’
     for (auto keyValueIt = _defaultHeaders.keyValueBegin(); keyValueIt != _defaultHeaders.keyValueEnd(); keyValueIt++) {
                                                                                           ^
client/CMakeFiles/client.dir/build.make:143: recipe for target 'client/CMakeFiles/client.dir/PFXPetApi.cpp.o' failed
make[2]: Leaving directory '/home/travis/build/OpenAPITools/openapi-generator/samples/client/petstore/cpp-qt/build'
make[2]: *** [client/CMakeFiles/client.dir/PFXPetApi.cpp.o] Error 1
make[1]: *** [client/CMakeFiles/client.dir/all] Error 2
CMakeFiles/Makefile2:164: recipe for target 'client/CMakeFiles/client.dir/all' failed
make[1]: Leaving directory '/home/travis/build/OpenAPITools/openapi-generator/samples/client/petstore/cpp-qt/build'
Makefile:132: recipe for target 'all' failed
make: *** [all] Error 2

Can you please take a look when you've time?

Travis build is run for master only due to free credits running low:

https://app.travis-ci.com/github/OpenAPITools/openapi-generator/builds/237210677

I'll comment out the job for the cpp test for the time being.

@MartinDelille
Copy link
Copy Markdown
Contributor Author

MartinDelille commented Sep 10, 2021

Ok I will have a look and revert the specific change if needed. Which Qt version runs the CI ?

@MartinDelille MartinDelille mentioned this pull request Sep 10, 2021
Merged
5 tasks
@MartinDelille MartinDelille deleted the cppcheck-fix branch September 12, 2021 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wing328 wing328 wing328 left review comments

Assignees

No one assigned

Labels

Client: C++ Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc. Enhancement: Code format Enhancement: General

Projects

None yet

Milestone

5.3.0

Development

Successfully merging this pull request may close these issues.

2 participants

@MartinDelille @wing328