Skip to content

[typescript-axios] Use CommonJS when using ES5 as target as per Typescript docs#10316

Merged
macjohnny merged 2 commits intoOpenAPITools:6.0.xfrom
ferferga:6.0.x
Sep 3, 2021
Merged

[typescript-axios] Use CommonJS when using ES5 as target as per Typescript docs#10316
macjohnny merged 2 commits intoOpenAPITools:6.0.xfrom
ferferga:6.0.x

Conversation

@ferferga
Copy link
Copy Markdown
Contributor

@ferferga ferferga commented Sep 2, 2021

Fixes failing tests in #10308 by fixing a mistake from myself according to TypeScript docs

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Copy Markdown
Member

wing328 commented Sep 3, 2021

cc @TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02)

Comment thread samples/client/petstore/typescript-axios/tests/default/tsconfig.json Outdated
@macjohnny macjohnny merged commit b01e3c9 into OpenAPITools:6.0.x Sep 3, 2021
@wing328 wing328 added this to the 5.3.0 milestone Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants