Skip to content

Handle nullable items in Go arrays#10268

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
therve:therve/go-nullable-items
Sep 9, 2021
Merged

Handle nullable items in Go arrays#10268
wing328 merged 1 commit intoOpenAPITools:masterfrom
therve:therve/go-nullable-items

Conversation

@therve
Copy link
Copy Markdown
Contributor

@therve therve commented Aug 26, 2021

If an item in a go array is nullable, we want to represent it as a pointer,
otherwise it will be deserialized with a default value and it will be
impossible to differentiate it from null.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

If an item in a go array is nullable, we want to represent it as a pointer,
otherwise it will be deserialized with a default value and it will be
impossible to differentiate it from null.
@therve therve force-pushed the therve/go-nullable-items branch from 81a0e9b to db852cf Compare September 7, 2021 12:07
@therve
Copy link
Copy Markdown
Contributor Author

therve commented Sep 8, 2021

@antihax (2017/11) @grokify (2018/07) @kemokemo (2018/09) @jirikuncar (2021/01) @ph4r5h4d (2021/04) 🙇

@wing328
Copy link
Copy Markdown
Member

wing328 commented Sep 9, 2021

LGTM but I've not tested it locally.

@wing328 wing328 merged commit 36ae0b9 into OpenAPITools:master Sep 9, 2021
@wing328
Copy link
Copy Markdown
Member

wing328 commented Sep 9, 2021

FYI. I've pushed a8ee07c to replace tabs with 4-space

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants