[typescript] Add headers to API error message#10153
Merged
macjohnny merged 1 commit intoOpenAPITools:masterfrom Oct 22, 2021
Merged
[typescript] Add headers to API error message#10153macjohnny merged 1 commit intoOpenAPITools:masterfrom
macjohnny merged 1 commit intoOpenAPITools:masterfrom
Conversation
Member
|
@jmadler thanks for the PR. Please resolve the merge conflicts when you've time. cc @TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02) |
TiFu
reviewed
Aug 26, 2021
Contributor
TiFu
left a comment
There was a problem hiding this comment.
Thanks for the PR!
TypeScript changes LGTM.
Looks like there are some changes in ruby files - is this just caused by some outdated samples?
aa29c5b to
35c58a5
Compare
Member
|
@jmadler can you merge the most recent master and regenerate the samples? |
35c58a5 to
ba17324
Compare
ba17324 to
b7a5e7d
Compare
macjohnny
reviewed
Oct 16, 2021
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup HTTP response body printing and add headers to ApiException object
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master,5.3.x,6.0.x