Skip to content

[typescript] Add headers to API error message#10153

Merged
macjohnny merged 1 commit intoOpenAPITools:masterfrom
jmadler:typescript-errors
Oct 22, 2021
Merged

[typescript] Add headers to API error message#10153
macjohnny merged 1 commit intoOpenAPITools:masterfrom
jmadler:typescript-errors

Conversation

@jmadler
Copy link
Copy Markdown
Contributor

@jmadler jmadler commented Aug 13, 2021

Cleanup HTTP response body printing and add headers to ApiException object

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.3.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Copy Markdown
Member

wing328 commented Aug 18, 2021

@jmadler thanks for the PR. Please resolve the merge conflicts when you've time.

cc @TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02)

Copy link
Copy Markdown
Contributor

@TiFu TiFu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

TypeScript changes LGTM.
Looks like there are some changes in ruby files - is this just caused by some outdated samples?

@jmadler jmadler force-pushed the typescript-errors branch 3 times, most recently from aa29c5b to 35c58a5 Compare August 30, 2021 20:47
@macjohnny
Copy link
Copy Markdown
Member

@jmadler can you merge the most recent master and regenerate the samples?

@jmadler jmadler changed the title [typescript] Cleanup HTTP response body error printing and add headers [typescript] Add headers to API error message Oct 15, 2021
@macjohnny
Copy link
Copy Markdown
Member

Cc @bodograumann

Copy link
Copy Markdown
Member

@macjohnny macjohnny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@macjohnny macjohnny merged commit e7dace6 into OpenAPITools:master Oct 22, 2021
@wing328 wing328 added this to the 5.3.0 milestone Oct 23, 2021
@jmadler jmadler deleted the typescript-errors branch November 2, 2021 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants