[go-server] Change Routes type from []Route to map[string]Route#10140
Closed
lwj5 wants to merge 3 commits intoOpenAPITools:masterfrom
Closed
[go-server] Change Routes type from []Route to map[string]Route#10140lwj5 wants to merge 3 commits intoOpenAPITools:masterfrom
[]Route to map[string]Route#10140lwj5 wants to merge 3 commits intoOpenAPITools:masterfrom
Conversation
lwj5
commented
Aug 12, 2021
Comment on lines
93
to
96
| wHeader := w.Header() | ||
| if headers != nil { | ||
| for key, values := range headers { | ||
| for _, value := range values { | ||
| wHeader.Add(key, value) | ||
| } | ||
| for key, values := range headers { | ||
| for _, value := range values { | ||
| wHeader.Add(key, value) | ||
| } | ||
| } |
Contributor
Author
There was a problem hiding this comment.
FYI: Linting complains range does not need to check for nil, hence removal of nil check
[]Route to map[string]Route[]Route to map[string]Route
Member
|
As discuss it's a breaking change so it should either target 6.0.x branch or the breaking change can be included in a new experimental generator if there're more breaking changes going into the go-server generator. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the operation ID should be unique for each API group, it is more rightly for the routes to be
map[string]Routeinstead of the name being a field of Route.Also, this allows for easy embedding compared to using []Route.
For example, if you wish to embed the controller and "override" a
DeleteOrderyou would have to "override" the wholeRoutes()method like so...Now with the new change, you may do:
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master,5.3.x,6.0.xHi @antihax @grokify @kemokemo @jirikuncar @ph4r5h4d, please help to take a look at this PR