Skip to content

Change the maven compile execution for Java 8 to override the default compile#89

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
nrayburn-tech:override-default-compile
Oct 14, 2025
Merged

Change the maven compile execution for Java 8 to override the default compile#89
wing328 merged 1 commit intoOpenAPITools:masterfrom
nrayburn-tech:override-default-compile

Conversation

@nrayburn-tech
Copy link
Copy Markdown
Contributor

@nrayburn-tech nrayburn-tech commented Oct 14, 2025

This avoids performing a default-compile, compile-java-8, and compile-java-9 execution. Only default-compile and compile-java-9 is executed.

compile-java-8 overwrites the output of default-compile right now, so there's no change in the end result of the class files with this PR.

Before this change

[INFO] --- compiler:3.14.1:compile (default-compile) @ jackson-databind-nullable ---
[INFO] Recompiling the module because of changed source code.
[INFO] Compiling 14 source files with javac [debug:lines,source,vars deprecation target 1.8] to target/classes
[WARNING] bootstrap class path not set in conjunction with -source 8
[INFO] 
[INFO] --- compiler:3.14.1:compile (compile-java-8) @ jackson-databind-nullable ---
[INFO] Recompiling the module because of added or removed source files.
[INFO] Compiling 14 source files with javac [debug:lines,source,vars deprecation release 8] to target/classes
[INFO] 
[INFO] --- compiler:3.14.1:compile (compile-java-9) @ jackson-databind-nullable ---
[INFO] Recompiling the module because of changed dependency.
[INFO] Compiling 1 source file with javac [debug:lines,source,vars deprecation release 9 module-path] to target/classes/META-INF/versions/9

After this change

[INFO] --- compiler:3.14.1:compile (default-compile) @ jackson-databind-nullable ---
[INFO] Recompiling the module because of changed source code.
[INFO] Compiling 14 source files with javac [debug:lines,source,vars deprecation release 8] to target/classes
[INFO] 
[INFO] --- compiler:3.14.1:compile (compile-java-9) @ jackson-databind-nullable ---
[INFO] Recompiling the module because of changed dependency.
[INFO] Compiling 1 source file with javac [debug:lines,source,vars deprecation release 9 module-path] to target/classes/META-INF/versions/9

@nrayburn-tech
Change the maven compile execution for Java 8 to override the default…
63cd80e 
… compile

This avoids performing a default-compile, compile-java-8, and compile-java-9 execution. Only default-compile and compile-java-9 is executed.
@wing328 wing328 merged commit 377e8c4 into OpenAPITools:master Oct 14, 2025
1 check passed
@nrayburn-tech nrayburn-tech deleted the override-default-compile branch October 18, 2025 20:53
@bf2robot bf2robot mentioned this pull request Aug 20, 2025
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Til7701 Til7701 Til7701 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nrayburn-tech @Til7701 @wing328