Skip to content

Skip SNAPSHOT deploy job on forks#70

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
ctrimble:feature_skip-snapshot-push-from-fork
Aug 22, 2025
Merged

Skip SNAPSHOT deploy job on forks#70
wing328 merged 1 commit intoOpenAPITools:masterfrom
ctrimble:feature_skip-snapshot-push-from-fork

Conversation

@ctrimble
Copy link
Copy Markdown
Contributor

This PR prevents forks from trying to run the publish-OSSRH job.

run: mvn -B test

publish-OSSRH:
if: github.repository == 'OpenAPITools/jackson-databind-nullable'
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the pr

what about checking if the ${{ secrets.ORG_GPG_PRIVATE_KEY }} is empty or not?

if it's defined, the owner of the repo (fork or official) wants to get it published (maybe internally behind firewall)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, I think it would be good to pin this specific job to your repo and wait to see if someone has a specific plan for adding support for others. It is always easier to widen something like this than shrink it.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure let's give it a try

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants