Skip to content

minor optimizations and simplifications to JsonNullable#43

Merged
cbornet merged 1 commit intoOpenAPITools:masterfrom
bratkartoffel:feature/minor-optimizations
Dec 10, 2022
Merged

minor optimizations and simplifications to JsonNullable#43
cbornet merged 1 commit intoOpenAPITools:masterfrom
bratkartoffel:feature/minor-optimizations

Conversation

@bratkartoffel
Copy link
Copy Markdown
Contributor

@bratkartoffel bratkartoffel commented Dec 9, 2022

Minor changes to JsonNullable, mainly warnings from my IDE:

  • JsonNullable is immutable, so set fields to final
  • Some generics definitions may be replayed by diamond-style
  • Use equals() and hashCode() from jre

@cbornet cbornet merged commit 4485fd1 into OpenAPITools:master Dec 10, 2022
@cbornet
Copy link
Copy Markdown
Member

cbornet commented Dec 10, 2022

Thanks @bratkartoffel !

@bratkartoffel bratkartoffel deleted the feature/minor-optimizations branch December 10, 2022 13:04
@bf2robot bf2robot mentioned this pull request Feb 13, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bratkartoffel @cbornet