Skip to content

Rebuild MODEL_ZOO #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kaijieshi7 merged 13 commits into from
Jan 28, 2022
Merged

Rebuild MODEL_ZOO #128

kaijieshi7 merged 13 commits into from
Jan 28, 2022

Conversation

@rentainhe
Copy link
Contributor

@rentainhe rentainhe commented Jan 27, 2022 •
edited
Loading

TODO

ChangeLog

  • Fix pretrained weight in vit_small_patch32_384, res2net50_48w_2s
  • Add resmlp_12_224_dino and resmlp_24_224_dino model and pretrained weight
  • Rebuild a cleaner model_zoo for flowvision

OneFlow bug

bug code:

import oneflow as flow
x = flow.randn(1, 3)
(x == 0).any()

fix PR: Oneflow-Inc/oneflow#7394

@kaijieshi7
Copy link
Contributor

kaijieshi7 commented Jan 27, 2022

确定全部重跑吗？

@rentainhe
Copy link
Contributor Author

rentainhe commented Jan 27, 2022

确定全部重跑吗？

V0.1.0发布前重新跑一下，之后就不用再跑了

@BBuf BBuf self-assigned this Jan 27, 2022
@BBuf BBuf mentioned this pull request Jan 27, 2022
Closed
@rentainhe rentainhe requested review from Ldpe2G and kaijieshi7 and removed request for kaijieshi7 January 28, 2022 09:49
kaijieshi7
kaijieshi7 approved these changes Jan 28, 2022
View reviewed changes
results/results_imagenet.md
| vgg13 | 69.940 | 30.060 | 89.256 | 10.742 | 133.1M | 224 | 0.875 | bilinear |
| vgg16 | 71.586 | 28.414 | 90.390 | 9.610 | 138.4M | 224 | 0.875 | bilinear |
| vgg19 | 72.394 | 27.606 | 90.886 | 9.114 | 143.7M | 224 | 0.875 | bilinear |
| vgg11_bn | 70.378 | 29.622 | 89.814 | 10.186 | 132.9M | 224 | 0.875 | bilinear |
Copy link
Contributor

@kaijieshi7 kaijieshi7 Jan 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

文档里面可以不用下划线，感觉不够美观。

flowvision/models/res_mlp.py

@ModelCreator.register_model
def resmlpB_24_dist(pretrained=False, progress=True, **kwargs):
def resmlp_big_24_distilled_224(pretrained=False, progress=True, **kwargs):
Copy link
Contributor

@kaijieshi7 kaijieshi7 Jan 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

蒸馏和原版应该只是权重不同，结构是相同的，那么这里是不是重复创建了两个一样的模型架构

@kaijieshi7 kaijieshi7 merged commit 2e6691b into main Jan 28, 2022
@kaijieshi7 kaijieshi7 deleted the rebuild_modelzoo branch January 28, 2022 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ldpe2G Ldpe2G Awaiting requested review from Ldpe2G

@oneflow-ci-bot oneflow-ci-bot Awaiting requested review from oneflow-ci-bot

1 more reviewer

@kaijieshi7 kaijieshi7 kaijieshi7 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kaijieshi7 kaijieshi7

@BBuf BBuf

@rentainhe rentainhe

Labels

Bug Fixes Improvements Priority: 0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rentainhe @kaijieshi7 @BBuf @oneflow-ci-bot