Skip to content

add any input bool #7394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
simonJJJ wants to merge 12 commits into from
Closed

add any input bool #7394

simonJJJ wants to merge 12 commits into from

Conversation

@simonJJJ
Copy link
Contributor

@simonJJJ simonJJJ commented Jan 27, 2022

No description provided.

@simonJJJ simonJJJ requested a review from BBuf January 27, 2022 10:52
@simonJJJ simonJJJ requested a review from lixinqi as a code owner January 27, 2022 10:52
BBuf
BBuf reviewed Jan 27, 2022
View reviewed changes
oneflow/user/kernels/reduce_kernel.cpp
#endif

#define REGISTER_REDUCE_LOGICAL_KERNELS(device) \
REGISTER_REDUCE_LOGICAL_XPU_KERNEL("reduce_any", BinaryFuncAny, device, bool) \
Copy link
Contributor

@BBuf BBuf Jan 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

补一组测试吧，Oneflow-Inc/vision#128 (comment) 把这个例子摘出来。

Copy link
Contributor Author

@simonJJJ simonJJJ Jan 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@github-actions
Copy link
Contributor

github-actions bot commented Jan 27, 2022

Code got formatted by CI. Please request CI again if you still want to have this PR merged. If the PR is from a forked repo, please download the patch files from the GitHub Actions web page and apply them locally.

@simonJJJ simonJJJ requested review from oneflow-ci-bot and removed request for oneflow-ci-bot January 27, 2022 11:44
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot January 27, 2022 13:11
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot January 27, 2022 14:39
@github-actions
Copy link
Contributor

github-actions bot commented Jan 27, 2022

CI failed when running job: cuda-misc. PR label automerge has been removed

@github-actions
Copy link
Contributor

github-actions bot commented Jan 27, 2022

Speed stats:

@oneflow-ci-bot oneflow-ci-bot removed their request for review January 27, 2022 18:28
@oneflow-ci-bot oneflow-ci-bot removed their request for review January 28, 2022 05:59
@oneflow-ci-bot oneflow-ci-bot self-requested a review January 28, 2022 05:59
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot January 28, 2022 08:49
@rentainhe rentainhe mentioned this pull request Jan 28, 2022
Merged
8 tasks
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot January 28, 2022 11:01
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot January 28, 2022 12:57
@oneflow-ci-bot oneflow-ci-bot self-requested a review January 28, 2022 14:50
@github-actions
Copy link
Contributor

github-actions bot commented Jan 28, 2022

Speed stats: 
GPU Name: GeForce GTX 1080 

✔️ OneFlow resnet50 time: 136.5ms (= 13646.8ms / 100, input_shape=[16, 3, 224, 224])
PyTorch resnet50 time: 140.5ms (= 14047.1ms / 100, input_shape=[16, 3, 224, 224])
✔️ Relative speed: 1.03 (= 140.5ms / 136.5ms)

✔️ OneFlow resnet50 time: 78.5ms (= 7850.8ms / 100, input_shape=[8, 3, 224, 224])
PyTorch resnet50 time: 82.6ms (= 8256.3ms / 100, input_shape=[8, 3, 224, 224])
✔️ Relative speed: 1.05 (= 82.6ms / 78.5ms)

OneFlow resnet50 time: 52.3ms (= 10469.1ms / 200, input_shape=[4, 3, 224, 224])
PyTorch resnet50 time: 55.7ms (= 11142.2ms / 200, input_shape=[4, 3, 224, 224])
✔️ Relative speed: 1.06 (= 55.7ms / 52.3ms)

OneFlow resnet50 time: 42.2ms (= 8440.5ms / 200, input_shape=[2, 3, 224, 224])
PyTorch resnet50 time: 48.0ms (= 9592.9ms / 200, input_shape=[2, 3, 224, 224])
✔️ Relative speed: 1.14 (= 48.0ms / 42.2ms)

OneFlow resnet50 time: 43.0ms (= 8601.0ms / 200, input_shape=[1, 3, 224, 224])
PyTorch resnet50 time: 38.5ms (= 7696.5ms / 200, input_shape=[1, 3, 224, 224])
❌ Relative speed: 0.89 (= 38.5ms / 43.0ms)

✔️ OneFlow resnet50 time: 145.9ms (= 14589.9ms / 100, input_shape=[16, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 156.2ms (= 15621.0ms / 100, input_shape=[16, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.07 (= 156.2ms / 145.9ms)

OneFlow resnet50 time: 88.6ms (= 8855.6ms / 100, input_shape=[8, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 98.2ms (= 9821.7ms / 100, input_shape=[8, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.11 (= 98.2ms / 88.6ms)

OneFlow resnet50 time: 63.8ms (= 12758.0ms / 200, input_shape=[4, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 70.5ms (= 14093.3ms / 200, input_shape=[4, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.10 (= 70.5ms / 63.8ms)

OneFlow resnet50 time: 55.6ms (= 11113.4ms / 200, input_shape=[2, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 62.9ms (= 12586.4ms / 200, input_shape=[2, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.13 (= 62.9ms / 55.6ms)

OneFlow resnet50 time: 55.3ms (= 11059.3ms / 200, input_shape=[1, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 57.8ms (= 11550.4ms / 200, input_shape=[1, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.04 (= 57.8ms / 55.3ms)

@github-actions
Copy link
Contributor

github-actions bot commented Jan 28, 2022

CI failed when running job: cuda-speed-test. PR label automerge has been removed

@oneflow-ci-bot oneflow-ci-bot removed their request for review January 28, 2022 18:47
@oneflow-ci-bot oneflow-ci-bot removed their request for review January 29, 2022 03:50
@chengtbf chengtbf deleted the add_any_input_bool branch April 13, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ldpe2G Ldpe2G Ldpe2G approved these changes

@lixinqi lixinqi Awaiting requested review from lixinqi

@daquexian daquexian Awaiting requested review from daquexian

@jackalcooper jackalcooper Awaiting requested review from jackalcooper

+1 more reviewer

@BBuf BBuf BBuf approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

automerge bug eager op

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@simonJJJ @Ldpe2G @BBuf @jackalcooper @oneflow-ci-bot