You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
On-call: the Skip until dialog on a schedule's Layers page says an overlap as the times are picked #7898
Since #7770 (issue #7630), the server refuses a user override that overlaps another override of the same person in the same scope (both on one policy, or both global). The Add User Override and Edit dialogs say it as soon as who is away and both times are picked, under Ends, with Edit that override, and hold the form back while it is so (UserOverrideOverlapNotice, wired in UserOverrideFormModal).
The Skip until... dialog on a schedule's Layers page (SkipLayerUserModal) adds the same kind of override - the person away, nobody covering, so the rotation takes their turns - with the same form fields, but without that notice. A skip that overlaps one already saved is only refused after Save, with the server's sentence under Ends, and there is no way to open the other override from there.
What to do
Hand the Skip dialog the same getEndsFooter and isKnownOverlap that UserOverrideFormModal passes to getUserOverrideFormFields, so it says the conflict - or, for a global override under a policy's own, the plain note - under Ends as the times are picked, and holds the form back on a conflict.
Edit that override from there opens that override's Edit dialog in the Skip dialog's place, as the schedule's active overrides card already does on the same page (ActiveOverridesCard).
Where it starts
packages/App/FeatureSet/Dashboard/src/Components/OnCallPolicy/OnCallScheduleLayer/SkipLayerUserModal.tsx; UserOverrides/UserOverrideFormModal.tsx shows the wiring to copy.
Tests
Like UserOverrideEditAndOverlapPages.test.tsx: the Skip dialog says a conflict under Ends and sends nothing; back to back is no conflict and saves; Edit that override opens the other one.
Activity
simlarsen commentedon Nov 17, 2026
Fixed in #9320, merged into main. It ships with the next release.