You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit e7bf356
Browse filesBrowse the repository at this point in the historyBrowse files
refactor: Make AggregateExec state modeling and public updates safe (part2: topk) (apache#25696)
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases.
You can link an issue to this PR using the GitHub syntax. For example
`Closesapache#123` indicates that this PR will close issue apache#123.
-->
- Closesapache#25563
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly
in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand
your changes and offer better suggestions for fixes.
Please explain the problem you are trying to solve in terms of the
user-visible
behavior, rather than the implementation.
For example, "The code in `foo.rs` doesn't handle nulls" is a symptom of
the
implementation. "COUNT(DISTINCT) returns wrong results when the column
contains
nulls" is the user-visible problem.
-->
See issue for the idea, this PR is the step 2 in the issue.
For backgrounds for aggregate topk optimization (this PR targets), see
-
https://github.com/apache/datafusion/pull/25696/changes#diff-4ac7ea0d6b4fd9ff25f1fcfaeda2b767a3d15d3ad5b6c1ba05fd7a5dfb805819R931
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here, but it
is sometimes worth providing a summary of the individual changes in this
PR.
-->
1. Represent topk path in `AggregateExec` with enum state
2. Deprecate unsafe APIs on `AggregateExec`, and replace them with a
atomic and safe one:
- Deprecated: `with_new_limit_options` and `with_limit_options`
- Safe and atomic alternative: `try_optimize_topk`
3. Update related optimizer passes to use the safe alternative
## What is the testing strategy for this PR?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
3. Serve as another way to document the expected behavior of the code
Briefly describe how this PR is tested, and point to the specific tests
you added. For example: 'This new feature is covered by the
`sqllogictest` cases added in `foo.slt`'.
If this PR does not add tests, explain why. For example, if the change
is already covered by existing tests, please mention it.
You should also check the `codecov` bot reply on this PR to confirm the
changed code is exercised.
-->
Existing tests (adapted the optimizer tests to use the new safe API for
the same test goal)
## Are there any user-facing changes?
Deprecating error-prone APIs on AggregateExec
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
// The combined aggregate groups raw input, like the partial.
126
+
group_by:Arc::clone(group_by),
127
+
limit:*limit,
128
+
},
129
+
_ => {
130
+
returninternal_err!(
131
+
"The AggregateKind should stay either (a) General (b) DistinctLimit introduced with the previous optimizer pass `LimitedDistinctAggregation`, it's impossible to have other variant"
0 commit comments