Repository navigation
Commit cfeb277
test: cover CrossJoinExec row metrics across batched inputs (apache#25530)
## Which issue does this PR close?
Part of apache#25333 (`CrossJoinExec` test coverage only).
## Rationale for this change
Join metrics can be incorrect without affecting query results. Existing
`CrossJoinExec` tests did not assert `build_input_rows` or `input_rows`
across different input batch layouts.
## What changes are included in this PR?
Adds Rust test coverage that:
* Verifies `build_input_rows`, `input_rows`, and `output_rows` for the
existing single-batch case.
* Runs the same 3 × 2 cross join with input batch sizes of 2 and 1.
* Confirms the row metrics remain 3, 2, and 6 regardless of input
batching.
This is a test-only change.
## What is the testing strategy for this PR?
```bash
cargo fmt --check
cargo test -p datafusion-physical-plan --lib joins::cross_join
cargo clippy -p datafusion-physical-plan --all-targets --all-features -- -D warnings
```
All checks pass locally.
## Are there any user-facing changes?
No.1 parent 49ed345 commit cfeb277
1 file changed
Lines changed: 70 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
706 | 706 | | |
707 | 707 | | |
708 | 708 | | |
709 | | - | |
| 709 | + | |
| 710 | + | |
| 711 | + | |
710 | 712 | | |
711 | 713 | | |
712 | 714 | | |
| |||
727 | 729 | | |
728 | 730 | | |
729 | 731 | | |
| 732 | + | |
| 733 | + | |
| 734 | + | |
| 735 | + | |
| 736 | + | |
| 737 | + | |
| 738 | + | |
| 739 | + | |
| 740 | + | |
| 741 | + | |
| 742 | + | |
| 743 | + | |
| 744 | + | |
| 745 | + | |
| 746 | + | |
| 747 | + | |
| 748 | + | |
| 749 | + | |
| 750 | + | |
| 751 | + | |
| 752 | + | |
| 753 | + | |
| 754 | + | |
730 | 755 | | |
731 | 756 | | |
732 | 757 | | |
| |||
966 | 991 | | |
967 | 992 | | |
968 | 993 | | |
| 994 | + | |
| 995 | + | |
| 996 | + | |
| 997 | + | |
| 998 | + | |
| 999 | + | |
| 1000 | + | |
| 1001 | + | |
| 1002 | + | |
| 1003 | + | |
| 1004 | + | |
| 1005 | + | |
| 1006 | + | |
| 1007 | + | |
| 1008 | + | |
| 1009 | + | |
| 1010 | + | |
| 1011 | + | |
| 1012 | + | |
| 1013 | + | |
| 1014 | + | |
| 1015 | + | |
| 1016 | + | |
| 1017 | + | |
| 1018 | + | |
| 1019 | + | |
| 1020 | + | |
| 1021 | + | |
| 1022 | + | |
| 1023 | + | |
| 1024 | + | |
| 1025 | + | |
| 1026 | + | |
| 1027 | + | |
| 1028 | + | |
| 1029 | + | |
| 1030 | + | |
| 1031 | + | |
| 1032 | + | |
| 1033 | + | |
| 1034 | + | |
| 1035 | + | |
| 1036 | + | |
| 1037 | + | |
969 | 1038 | | |
970 | 1039 | | |
971 | 1040 | | |
| |||
0 commit comments