Repository navigation
Commit 2bc02b9
Expand scalar async UDF results to the batch row count (apache#25828)
## Which issue does this PR close?
- Closes apache#25875
## Rationale for this change
When an async UDF returns a `ColumnarValue::Scalar` (e.g. all arguments
are literals), queries on more than one row fail with `all columns in a
record batch must have the same length`.
## What changes are included in this PR?
`AsyncFuncExpr::invoke_with_args` expands each result to its chunk's row
count via `into_array_of_size`, instead of turning a scalar into a 1-row
array.
## What is the testing strategy for this PR?
Added `test_async_udf_with_scalar_result` in
`user_defined_async_scalar_functions.rs`. It fails without the fix.
## Are there any user-facing changes?
No.1 parent fd0a945 commit 2bc02b9
2 files changed
Lines changed: 34 additions & 11 deletions
File tree
- datafusion
- core/tests/user_defined
- physical-expr/src
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
89 | 89 | | |
90 | 90 | | |
91 | 91 | | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
92 | 121 | | |
93 | 122 | | |
94 | 123 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
162 | 162 | | |
163 | 163 | | |
164 | 164 | | |
165 | | - | |
| 165 | + | |
| 166 | + | |
166 | 167 | | |
167 | 168 | | |
168 | 169 | | |
| |||
181 | 182 | | |
182 | 183 | | |
183 | 184 | | |
184 | | - | |
| 185 | + | |
| 186 | + | |
185 | 187 | | |
186 | 188 | | |
187 | 189 | | |
188 | | - | |
189 | | - | |
190 | | - | |
191 | | - | |
192 | | - | |
193 | | - | |
194 | | - | |
195 | | - | |
196 | 190 | | |
197 | | - | |
| 191 | + | |
198 | 192 | | |
199 | 193 | | |
200 | 194 | | |
| |||
0 commit comments