Repository navigation
Commit 1ffb342
bench: cover dictionary group keys with a shared values array (apache#25198)
## Which issue does this PR close?
[Related to apache#24822. No issue
closed.](apache#25185)
## Rationale for this change
The benchmarks in this file build a fresh values array per batch and cap
cardinality at the batch size. Neither shape matches a real plan: `take`
and `filter` clone the values `Arc` and rewrite only the keys, so
batches downstream of a repartition share one values array, and because
it is never compacted its cardinality can far exceed the rows in a
batch. Per-batch work that scales with dictionary cardinality is
invisible under the current parameters.
## What changes are included in this PR?
Adds `bench_shared_values_arc`: 32 batches of 8192 rows sharing one
values array, at cardinalities 8192, 100k and 500k.
## What is the testing strategy for this PR?
Benchmark-only. Ran the bench locally and `cargo clippy --all-targets -D
warnings`.
## Are there any user-facing changes?
No1 parent 98c0534 commit 1ffb342
1 file changed
Lines changed: 73 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
247 | 247 | | |
248 | 248 | | |
249 | 249 | | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
| 310 | + | |
| 311 | + | |
| 312 | + | |
| 313 | + | |
| 314 | + | |
| 315 | + | |
| 316 | + | |
| 317 | + | |
| 318 | + | |
| 319 | + | |
| 320 | + | |
250 | 321 | | |
251 | 322 | | |
252 | 323 | | |
253 | 324 | | |
254 | 325 | | |
255 | | - | |
| 326 | + | |
| 327 | + | |
256 | 328 | | |
257 | 329 | | |
0 commit comments