Skip to content

test(server): remove duplicate missing worktree test (pingdotgg#8252) - #1

Merged
Olivier-OG merged 153 commits into
mainfrom
sync-fork-with-upstream
Sep 1, 2026
Merged

Olivier-OG merged 153 commits into
mainfrom
sync-fork-with-upstream

Conversation

@Olivier-OG

Copy link
Copy Markdown
Owner

Thread title, branch name, commit message and PR content generation all funnel
through runClaudeJson, which spawned the Claude CLI with
--dangerously-skip-permissions. The helper only has to emit JSON, so a
tool-enabled session with permission checks off was pure downside: it makes
every first turn execute a skill embedded in the user's own message
(pingdotgg#3594, pingdotgg#4061, pingdotgg#5734), and it violates a least-privilege policy
that forbids skipped permissions outright, regardless of the runtime mode
picked in the composer.

Replaces the flag with the tool isolation from the upstream PR pingdotgg#4062 branch:
--tools "" as the primary restriction, plus --permission-mode dontAsk, an
explicit built-in denylist and --strict-mcp-config as defence in depth for CLI
versions that treat an empty --tools value as absent.

The PR's regression test did not apply -- the fake-Claude stub has since been
rewritten from sh to Node -- so it is ported to the current harness, which
already supports argument assertions: the spawn must contain the isolation
flags and must not contain the bypass flag.

Verified: both changed files transpile cleanly (esbuild), and
--dangerously-skip-permissions no longer appears anywhere under apps/server/src.
Not run: the server test suite, typecheck and lint, which need a full pnpm
install of the monorepo.<!--
⚠️ READ BEFORE OPENING ⚠️

We are not actively accepting contributions right now.

You can still open a PR, but please do so knowing there is a high chance
we may close it without merging it, or never review it.

  • Small, focused PRs are strongly preferred. Bug fixes are most likely to be merged.
  • New features will most likely just annoy us.
  • 1,000+ line PRs with a bunch of new features will probably get you banned from the repo.
    -->

What Changed

Why

UI Changes

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes
    Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>

t3-code-bot Bot and others added 30 commits August 27, 2026 09:47
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
Co-authored-by: Julius Marminge <[email protected]>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
Co-authored-by: Julius Marminge <[email protected]>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
Recent scheduled nightlies have been delayed or skipped.

Move the nightly cron from minute 7 to minute 38. Keep the existing three-hour interval. This tests a different point in each three-hour window without claiming it will fix GitHub schedule delivery.

Authored by GPT-5.6 Sol with the Codex harness.
Add a mod+shift+p shortcut that pins or unpins the active thread. Ignore the shortcut during terminal focus and when the server does not support thread pinning.
…mproving launch times (pingdotgg#5769)

Co-authored-by: Claude Opus 5 <[email protected]>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
Co-authored-by: Utkarsh Patil <[email protected]>
t3dotgg and others added 26 commits September 1, 2026 03:24
…g#8367)

Reuse one server config subscription for session bootstrap and live updates.

Preserve environment theme opt-in, replay, deletion, slow subscriber recovery, and config stream failure handling.

Co-authored-by: Adamulek123 <[email protected]>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
Co-authored-by: maria <[email protected]>
…ream

* upstream/main: (152 commits)
  chore(release): prepare v0.0.38
  fix(chat): keep latest command live between messages (pingdotgg#9098)
  fix(web): preserve theme when toggling advanced colors (pingdotgg#8500)
  fix(web): keep the selected environment when changing projects (pingdotgg#9102)
  fix(web): keep theme placeholder text dimmer than entered text (pingdotgg#9104)
  fix(web): changing projects no longer creates a draft (pingdotgg#9097)
  fix(web): sync sidebar PR state from open panel (pingdotgg#9092)
  Revert "fix(chat): reuse one row for live activity" (pingdotgg#9096)
  feat(models): discover Claude models from remote manifest (pingdotgg#9084)
  fix(chat): reuse one row for live activity (pingdotgg#9062)
  feat(web): open project settings from thread menus (pingdotgg#8925)
  feat(desktop): add configurable quit shortcut confirmation (pingdotgg#9076)
  fix(preview): restore recording and macOS rendering after Electron 43 (pingdotgg#9001)
  feat(claude): add Claude Fable 5.1 model (pingdotgg#9078)
  fix(server): cache project favicon resolution (pingdotgg#9080)
  fix(mobile): keep thread scroll bounds current after animations (pingdotgg#9013)
  feat(shortcuts): copy active thread reference (pingdotgg#8994)
  fix(web): block type-to-focus behind open dialogs (pingdotgg#8139)
  fix(web): align un-settle banner action (pingdotgg#9033)
  perf(client-runtime): halve server config bootstrap traffic (pingdotgg#8367)
  ...

# Conflicts:
#	apps/server/src/textGeneration/ClaudeTextGeneration.test.ts
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL labels Sep 1, 2026
@Olivier-OG
Olivier-OG merged commit b7a0e73 into main Sep 1, 2026
6 of 15 checks passed
@RubMertens
RubMertens deleted the sync-fork-with-upstream branch September 21, 2026 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.