dkg: fixed edit remove-operators #4147
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the edit remove-operators command logic within the DKG (Distributed Key Generation) reshare functionality. The fix addresses how removed operators are identified and handled during the reshare ceremony, particularly when removed nodes may still participate to transfer their key shares.
Key Changes:
- Added nil-safety check when looking up removed operators in the peer map (preventing panics when removed nodes don't participate)
- Refactored node classification logic to properly filter out removed nodes from the
newNodeslist - Added detailed comments explaining the semantics of oldNodes/newNodes in remove-only vs add-only scenarios
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4147 +/- ##
==========================================
- Coverage 56.43% 56.41% -0.02%
==========================================
Files 245 245
Lines 31175 31198 +23
==========================================
+ Hits 17593 17600 +7
- Misses 11273 11285 +12
- Partials 2309 2313 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
pinebit
added
the
merge when ready
Fixed bug found in
edit remove-operatorscommand logic.category: bug
ticket: none