Skip to content

Conversation

@pinebit
Copy link
Collaborator

@pinebit pinebit commented Nov 25, 2025

The test was generating invalid ENR strings using simple hex formatting (enr://%x). Updated to use testutil.RandomENR() which generates proper EIP-778 compliant ENR records with correct RLP and base64 encoding.

category: test
ticket: none

@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Nov 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.41%. Comparing base (4137969) to head (dcee0f8).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4124      +/-   ##
==========================================
- Coverage   56.41%   56.41%   -0.01%     
==========================================
  Files         245      245              
  Lines       31175    31175              
==========================================
- Hits        17587    17586       -1     
- Misses      11276    11280       +4     
+ Partials     2312     2309       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pinebit pinebit added the merge when ready Indicates bulldozer bot may merge when all checks pass label Nov 25, 2025
@obol-bulldozer obol-bulldozer bot merged commit 1131afe into main Nov 25, 2025
12 checks passed
@obol-bulldozer obol-bulldozer bot deleted the pinebit/fix-testdata-enr branch November 25, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge when ready Indicates bulldozer bot may merge when all checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants