-
Notifications
You must be signed in to change notification settings - Fork 134
*: bump-minor-version gh action #4084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new GitHub Actions workflow to automate the creation of minor version release branches and pull requests.
Key Changes:
- Adds
bump-minor-version.ymlworkflow that calculates the next minor version, creates a release branch, updates the version file, and creates a PR - Uses
mathieudutour/[email protected]to determine version bumps andpeter-evans/create-pull-request@v6to create PRs - Supports configurable version file paths with a default of
app/version/version.go
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]> Signed-off-by: Andrei Smirnov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]> Signed-off-by: Andrei Smirnov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 14 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4084 +/- ##
==========================================
- Coverage 56.43% 56.35% -0.08%
==========================================
Files 245 245
Lines 31116 31169 +53
==========================================
+ Hits 17561 17566 +5
- Misses 11248 11289 +41
- Partials 2307 2314 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| echo "::notice file=$VERSION_FILE,line=18::Bumping version in $VERSION_FILE to $NEW_VERSION" | ||
|
|
||
| # Use sed to find the line and replace only the version string | ||
| sed -i -E "s/^(var version = ).*/\1\"$NEW_VERSION\"/" "$VERSION_FILE" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will essentially update v1.8-dev to v1.8.0.
What we'd like so make it v1.8-rc, no?
The v1.8.0 we should make with a git tag and change the version in this file to v1.8.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overlooked the -rc part..
Update version/version.go line 18 from var version = "<FULL_VERSION>-dev" to var version = "<FULL_VERSION>-rc". Commit and push the change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated.
Signed-off-by: Diogo Santos <[email protected]>
Signed-off-by: Diogo Santos <[email protected]>
|
Introduces `tag-minor-release-candidate.yml` GH action. This action finds the latest release branch (ideally, created from `bump-minor-version.yml` #4084) such as `main-vX.Y`, creates a version prefix `vX.Y.0`, finds the latest release candidate for this version such as `vX.Y.0-rcZ` and creates/pushes a new release candidate tag `vX.Y.0-rc(Z+1)`. category: misc ticket: #3933
Introduces `prepare-minor-full-release.yml` and `tag-minor-full-release.yml` GH action. `prepare-minor-full-release.yml` finds the latest release branch (e.g., `main-vX.Y` created from `bump-minor-version.yml` #4084), creates a PR to update release branch version from `vX.Y-rc` to `vX.Y.0` (stable release), and creates a PR to update main branch version from `vX.Y-dev` to `vX.(Y+1)-dev`. `tag-minor-full-release.yml` validates that the stable version PR has been merged, creates and pushes the tag `vX.Y.0`, and can auto-detect latest release branch or accept manual input. Workflow: Run `prepare-minor-full-release.yml` to create the PRs, review and merge the stable version PR to the release branch, run `tag-minor-full-release.yml` to create and push the tag, then merge the dev version PR to main to start the next development cycle. category: misc ticket: #3933



Introducing
bump-minor-version.ymlGH action.category: misc
ticket: #3933