*: remaining errors revamp #4050
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors error messages across remaining packages to follow a consistent style guideline: removing conversational prefixes like "cannot", "can't", "couldn't", "doesn't" and rephrasing messages to be more concise and direct. The changes standardize error messages to use imperative mood without unnecessary prefixes and clarify configuration requirements.
- Simplified error message phrasing by removing conversational language
- Standardized flag-related error messages to use consistent format
- Improved clarity of verification and validation error messages
Reviewed Changes
Copilot reviewed 35 out of 36 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| testutil/obolapimock/obolapi_exit.go | Simplified JSON marshaling error message |
| testutil/genchangelog/main.go | Removed "can't" prefix from tag parsing errors |
| testutil/compose/define.go | Reworded environment variable error for clarity |
| testutil/compose/auto.go | Changed "couldn't" to "could not" in alert polling error |
| dkg/protocol.go | Standardized verification error messages |
| dkg/exchanger.go | Simplified context error message |
| dkg/dkg_internal_test.go | Standardized keymanager flag error messages in tests |
| dkg/dkg.go | Updated keymanager and test flag error messages |
| dkg/disk_internal_test.go | Changed "doesn't" to "does not" for consistency |
| dkg/disk.go | Standardized directory and verification error messages |
| dkg/bcast/impl.go | Simplified signature verification error |
| cmd/testmev_internal_test.go | Standardized beacon node endpoint error in test |
| cmd/testmev.go | Updated beacon node and load test flag error messages |
| cmd/testbeacon.go | Clarified POST request error message |
| cmd/run_internal_test.go | Simplified nickname length error in test |
| cmd/run.go | Updated nickname validation error message |
| cmd/relay/relay.go | Removed "failed to" prefix from conversion errors |
| cmd/manifest_tools.go | Simplified verification error messages |
| cmd/edit_removeoperators_internal_test.go | Updated private key load error in test |
| cmd/edit_recreateprivatekeys_internal_test.go | Simplified validator keys directory error in test |
| cmd/edit_recreateprivatekeys.go | Updated validator keys directory validation error |
| cmd/edit_addvalidators_internal_test.go | Standardized validation error messages in tests |
| cmd/edit_addvalidators.go | Updated num-validators and validator keys validation errors |
| cmd/createdkg_internal_test.go | Simplified threshold validation errors in tests |
| cmd/createdkg.go | Updated threshold validation error messages |
| cmd/createcluster_internal_test.go | Standardized flag conflict and validation errors in tests |
| cmd/createcluster.go | Updated threshold, keymanager, and validation error messages |
| cmd/combine/combine.go | Removed "cannot"/"can't" prefixes from file operation errors |
| cluster/manifest/load_test.go | Changed "don't match" to "mismatch" for consistency |
| cluster/manifest/load.go | Simplified manifest loading and hash comparison errors |
| cluster/lock.go | Clarified signature verification error message |
| cluster/helpers_internal_test.go | Updated directory validation error in test |
| cluster/helpers.go | Simplified non-empty directory error |
| cluster/definition.go | Removed "the" prefix and standardized version support errors |
| CLAUDE.md | Added knowledge base section with documentation links |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4050 +/- ##
==========================================
+ Coverage 53.81% 54.79% +0.97%
==========================================
Files 242 242
Lines 39425 31040 -8385
==========================================
- Hits 21217 17007 -4210
+ Misses 15965 11793 -4172
+ Partials 2243 2240 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
KaloyanTanev
approved these changes
Oct 23, 2025
|
|
||
| if resp.StatusCode/100 != 2 { | ||
| return 0, errors.New("post failed", z.Int("status", resp.StatusCode)) | ||
| return 0, errors.New("post request failed", z.Int("status", resp.StatusCode)) |
Collaborator
There was a problem hiding this comment.
Suggested change
| return 0, errors.New("post request failed", z.Int("status", resp.StatusCode)) | |
| return 0, errors.New("POST request failed", z.Int("status", resp.StatusCode)) |
Collaborator
Author
There was a problem hiding this comment.
cannot start error with capital letter, we have this rule in the pre-commit
|
pinebit
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remaining packages errors revamp with claude.
category: refactor
ticket: #3882