core/tracker: handle 404 errors gracefully #4041
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR improves the inclusion checker's error handling by treating 404 responses from the beacon node as valid "block not found" scenarios rather than errors. When a block proposal is missed (no block at a slot), the beacon node returns a 404, which previously caused unnecessary retries and spurious warnings.
Key Changes:
- Added 404 status code detection using
z.ContainsField()utility in bothcheckBlockandcheckBlockAndAttsfunctions - Modified error handling to return nil for 404 responses, stopping unnecessary retries
- Added comprehensive test coverage for both 404 and non-404 error scenarios
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| core/tracker/inclusion.go | Added 404 error handling in checkBlock and checkBlockAndAtts to treat missing blocks as valid scenarios |
| core/tracker/inclusion_internal_test.go | Added comprehensive test suite covering 404 handling for both block and attestation checks, plus validation that non-404 errors still propagate |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
pinebit
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4041 +/- ##
=======================================
Coverage 53.79% 53.80%
=======================================
Files 242 242
Lines 39412 39425 +13
=======================================
+ Hits 21203 21213 +10
- Misses 15967 15970 +3
Partials 2242 2242 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
KaloyanTanev
approved these changes
Oct 22, 2025
DiogoSantoss
approved these changes
Oct 22, 2025
pinebit
added
the
merge when ready
KaloyanTanev
pushed a commit
that referenced
this pull request
Oct 23, 2025
Fix: Handle 404 errors gracefully in inclusion checker and improve error handling **Problem** The inclusion checker was treating 404 responses from the beacon node as errors, causing: - Unnecessary retries when blocks are missed, putting load on the beacon node - Spurious warnings for expected 404 responses (missed proposals are valid) **Solution** 1. Handle 404 errors gracefully Detect 404 status codes and treat them as "block not found" (expected behavior) Stop retrying and stop logging warnings for 404 responses Added comprehensive tests to verify correct behavior 2. Improve error handling approach Modified eth2wrap.wrapError() to use errors.Wrap() instead of errors.New() Preserves original eth2api.Error in the error chain Enables standard Go error checking with errors.As() instead of relying on logging fields Applied consistently across inclusion.go and synthproposer.go category: bug ticket: #4035
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Handle 404 errors gracefully in inclusion checker and improve error handling
Problem
The inclusion checker was treating 404 responses from the beacon node as errors, causing:
Solution
Detect 404 status codes and treat them as "block not found" (expected behavior)
Stop retrying and stop logging warnings for 404 responses
Added comprehensive tests to verify correct behavior
Modified eth2wrap.wrapError() to use errors.Wrap() instead of errors.New()
Preserves original eth2api.Error in the error chain
Enables standard Go error checking with errors.As() instead of relying on logging fields
Applied consistently across inclusion.go and synthproposer.go
category: bug
ticket: #4035