app/sse: fix bucket delay values #4029
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4029 +/- ##
==========================================
+ Coverage 53.47% 53.50% +0.03%
==========================================
Files 224 224
Lines 37354 37354
==========================================
+ Hits 19975 19987 +12
+ Misses 15256 15248 -8
+ Partials 2123 2119 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
KaloyanTanev
approved these changes
Oct 14, 2025
DiogoSantoss
added
the
merge when ready
KaloyanTanev
pushed a commit
that referenced
this pull request
Oct 23, 2025
Delay event values were being passed as `float64(delay)` instead of `delay.Seconds()` which causes Prometheus to store them incorrectly. category: bug ticket: none
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delay event values were being passed as
float64(delay)instead ofdelay.Seconds()which causes Prometheus to store them incorrectly.category: bug
ticket: none