Skip to content

Conversation

@DiogoSantoss
Copy link
Contributor

Avoid checking fee recipient when builder is enabled to reduce unnecessary warning.

category: refactor
ticket: none

@DiogoSantoss DiogoSantoss self-assigned this Aug 28, 2025
@sonarqubecloud
Copy link

@DiogoSantoss DiogoSantoss changed the title core/fetcher: avoid checking fee recipient with enabled builder core/fetcher: improve fee recipient checking Aug 28, 2025
@codecov
Copy link

codecov bot commented Aug 28, 2025

Codecov Report

❌ Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.09%. Comparing base (3ee786f) to head (73a9490).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
core/fetcher/fetcher.go 20.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3937      +/-   ##
==========================================
- Coverage   55.14%   55.09%   -0.05%     
==========================================
  Files         225      225              
  Lines       37204    37206       +2     
==========================================
- Hits        20517    20500      -17     
- Misses      14520    14535      +15     
- Partials     2167     2171       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DiogoSantoss DiogoSantoss added the merge when ready Indicates bulldozer bot may merge when all checks pass label Aug 29, 2025
@obol-bulldozer obol-bulldozer bot merged commit ee6f423 into main Aug 29, 2025
13 of 18 checks passed
@obol-bulldozer obol-bulldozer bot deleted the diogo/builder-fee-recipient branch August 29, 2025 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge when ready Indicates bulldozer bot may merge when all checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants