app: fallback buildinfo logic #3930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
DiogoSantoss
approved these changes
Aug 26, 2025
KaloyanTanev
approved these changes
Aug 26, 2025
pinebit
added
the
merge when ready
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3930 +/- ##
==========================================
- Coverage 55.06% 55.01% -0.06%
==========================================
Files 225 225
Lines 36837 36857 +20
==========================================
- Hits 20285 20276 -9
- Misses 14409 14439 +30
+ Partials 2143 2142 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DiogoSantoss
pushed a commit
that referenced
this pull request
Aug 26, 2025
Enable fallback logic for buildinfo. Now this supports two options to specify buildinfo: using -X linker flags and -buildvcs, depending on the context (pre-built binaries vs docker). category: bug ticket: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable fallback logic for buildinfo. Now this supports two options to specify buildinfo: using -X linker flags and -buildvcs, depending on the context (pre-built binaries vs docker).
category: bug
ticket: none