p2p: error on closing canceled stream #3916
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3916 +/- ##
==========================================
- Coverage 55.07% 55.06% -0.02%
==========================================
Files 225 225
Lines 36842 36854 +12
==========================================
+ Hits 20291 20292 +1
- Misses 14410 14422 +12
+ Partials 2141 2140 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
KaloyanTanev
approved these changes
Aug 19, 2025
Collaborator
KaloyanTanev
left a comment
KaloyanTanev
left a comment
There was a problem hiding this comment.
Approving with the assumption that the elaborate tests we've done still result in success.
pinebit
approved these changes
Aug 20, 2025
DiogoSantoss
added
the
merge when ready
DiogoSantoss
added a commit
that referenced
this pull request
Aug 20, 2025
Functions `SendReceive` and `Send` create a libp2p stream to send a message to a peer that is closed at the end. Upon enabling QUIC an error `close called for canceled stream` start appearing more often which would cause the function to return the error signaling a failure in sending the message. This would trigger a retry mechanism and add lots of logs. Upon testing, we verified that this retry is not necessary since the destination peer would receive the message anyways even if we failed to close the stream. This should also not cause any leaks since the stream was canceled. We still do not know who/what is causing the stream to be canceled. The PR simply aims to reduce unnecessary retries and logs. category: bug ticket: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functions
SendReceiveandSendcreate a libp2p stream to send a message to a peer that is closed at the end. Upon enabling QUIC an errorclose called for canceled streamstart appearing more often which would cause the function to return the error signaling a failure in sending the message. This would trigger a retry mechanism and add lots of logs.Upon testing, we verified that this retry is not necessary since the destination peer would receive the message anyways even if we failed to close the stream. This should also not cause any leaks since the stream was canceled.
We still do not know who/what is causing the stream to be canceled.
The PR simply aims to reduce unnecessary retries and logs.
category: bug
ticket: none