dkg: add zipped flag #3903
Merged
dkg: add zipped flag #3903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3903 +/- ##
========================================
Coverage 55.12% 55.12%
========================================
Files 225 225
Lines 36696 36832 +136
========================================
+ Hits 20229 20304 +75
- Misses 14344 14390 +46
- Partials 2123 2138 +15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pinebit
approved these changes
Aug 12, 2025
Collaborator
pinebit
left a comment
pinebit
left a comment
There was a problem hiding this comment.
Make sure this is documented in the public docs.
pinebit
reviewed
Aug 13, 2025
| bindEth1Flag(cmd.Flags(), &config.ExecutionEngineAddr) | ||
|
|
||
| cmd.Flags().DurationVar(&config.Timeout, "timeout", 1*time.Minute, "Timeout for the DKG process, should be increased if DKG times out.") | ||
| cmd.Flags().BoolVar(&config.Zipped, "zipped", false, "Create a tar archive compressed with gzip of the target directory after creation.") |
Collaborator
There was a problem hiding this comment.
Consider adding the same flag to add-validators. It has the same dkg semantic.
Contributor
Author
There was a problem hiding this comment.
Will do in a separate PR
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
KaloyanTanev
approved these changes
Aug 13, 2025
DiogoSantoss
added
the
merge when ready
DiogoSantoss
added a commit
that referenced
this pull request
Aug 13, 2025
Add `zipped` flag to `charon dkg` command to create a gzip tarball file of the output files of DKG. It will compress/archive the contents of `dataDir` into a file named `dkg.tar.gz` and delete the original files. category: feature ticket: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
zippedflag tocharon dkgcommand to create a gzip tarball file of the output files of DKG.It will compress/archive the contents of
dataDirinto a file nameddkg.tar.gzand delete the original files.category: feature
ticket: none