Skip to content

enhancement/root analysis_settings.json not updated when run is complete#1875

Merged
sambles merged 5 commits intomainfrom
feature/combined-analysis-settings
Feb 26, 2026
Merged

enhancement/root analysis_settings.json not updated when run is complete#1875
sambles merged 5 commits intomainfrom
feature/combined-analysis-settings

Conversation

@vinulw
Copy link
Copy Markdown
Contributor

@vinulw vinulw commented Feb 13, 2026

enhancement/root analysis_settings.json not updated when run is complete

  • make output-dir/analysis_settings.json match output-dir/output/analysis_settings.json

@vinulw vinulw self-assigned this Feb 13, 2026
@vinulw vinulw linked an issue Feb 13, 2026 that may be closed by this pull request
@vinulw vinulw marked this pull request as ready for review February 18, 2026 16:47
@vinulw vinulw changed the title save combine analysis settings enhancement/root analysis_settings.json not updated when run is complete Feb 18, 2026
@vinulw vinulw requested review from SkylordA and sstruzik February 18, 2026 16:48
@sstruzik
Copy link
Copy Markdown
Contributor

This duplicate the analysis file in two folders. We probably should only have one, maybe with a rename.
Not sure if it worth the effort but.
Is it feasible to either?

  • remove the one in output, rename the original one in run_dir (with a suffix like _input, _user or _origin)
  • point the process that consume the setting after to the output one

@SkylordA
Copy link
Copy Markdown
Contributor

ditto comment above ^

@vinulw
Copy link
Copy Markdown
Contributor Author

vinulw commented Feb 24, 2026

This duplicate the analysis file in two folders. We probably should only have one, maybe with a rename. Not sure if it worth the effort but. Is it feasible to either?

  • remove the one in output, rename the original one in run_dir (with a suffix like _input, _user or _origin)
  • point the process that consume the setting after to the output one

The analysis settings file in run_dir/analysis_settings.json seems to not be used by the rest of the computation.

Moved so that the user / input analysis settings file can be found in run_dir/input/analysis_settings.json for reference.

The run_dir/output/analysis_settings.json is the one with the merged settings.

@sambles sambles mentioned this pull request Feb 26, 2026
@sambles sambles merged commit 2200fbd into main Feb 26, 2026
17 of 25 checks passed
@sambles sambles deleted the feature/combined-analysis-settings branch February 26, 2026 15:28
@awsbuild awsbuild added this to the 2.5.1 milestone Feb 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

save combined analysis settings in outputs

5 participants