Conversation
657a1c6 to
f6c8ea9
Compare
vinulw
reviewed
Jan 29, 2026
| "FMTermGroupID": 12, | ||
| "ProfileType": "Acc" | ||
| }, | ||
| "PolDedLIA": { |
Contributor
There was a problem hiding this comment.
Minor: In OEDExposureDataSpec v4.0.0 the code for this is LIAB. Might be worth changing to match
Contributor
There was a problem hiding this comment.
as far as i can tell there is no test for CYB coverages (i.e. coverage_id). may be worth adding to test the grouped cyber?
Contributor
Author
There was a problem hiding this comment.
I agree, I try to add the combine cyber, but as the column doesn't exist yet the test fails if I add it.
vinulw
approved these changes
Jan 30, 2026
benhayes21
approved these changes
Feb 2, 2026
sambles
pushed a commit
that referenced
this pull request
Feb 5, 2026
* add cyber fm terms * add cyber tests * set CYB as all coverage for cyber * fixup * fix tests * change LIA to LIAB => no support in OED 3for this column
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
support for cyber risk financial module
This PR adds support for cyber risk financial module (FM) terms to the OasisLMF framework, enabling the modeling of cyber insurance policies.
Added policy-level deductible and limit terms for 10 new cyber coverage types:
Updated exposure run logic to handle use cases without location files (e.g., cyber, marine), where exposures are defined at account level only.
Bug Fixes
Tests (tests/fm/test_fmpy.py)
Added two new FM acceptance tests for cyber: