Skip to content

feature/extra_oedversion_source#1844

Merged
SkylordA merged 6 commits intomainfrom
feature/extra_oedversion_sources
Feb 2, 2026
Merged

feature/extra_oedversion_source#1844
SkylordA merged 6 commits intomainfrom
feature/extra_oedversion_sources

Conversation

@SkylordA
Copy link
Copy Markdown
Contributor

@SkylordA SkylordA commented Jan 23, 2026 •
edited
Loading

feature/extra_oedversion_sources

Adds option to set oed version for schema from analysis settings and from exposure files.

Order of priority

CLI  # First
Oasis config file (oasislmf.json)
analysis_settings.json
exposure files (oedversion column)
ODS_Tools version  # Last

NOTE for users: Using OED Specifications below 3.1.0 will likely cause an error due to different schema formats.

closes OasisLMF/ODS_Tools#224

@SkylordA SkylordA self-assigned this Jan 23, 2026
@SkylordA SkylordA added enhancement New feature or request feature A main feature, captured on the backlog labels Jan 23, 2026
@SkylordA
Copy link
Copy Markdown
Contributor Author

SkylordA commented Jan 29, 2026

NOTE: Sorry for massive PR, pretty much 99% of the changes are csv files in tests and validation to change OEDVersion from whatever it was before to "latest version". Just look at the oasislmf folder changes, should be straightforward one line changes for these files.

@SkylordA
Copy link
Copy Markdown
Contributor Author

SkylordA commented Jan 29, 2026

NOTE: currently an unrelated test is failing (tests/utils/test_data_exposure.py). Once this is fixed on main, this PR should be fine to merge

@SkylordA SkylordA mentioned this pull request Jan 29, 2026
Merged
@SkylordA SkylordA merged commit 75c758f into main Feb 2, 2026
26 checks passed
@awsbuild awsbuild added this to the 2.5.0 milestone Feb 8, 2026
@sambles sambles deleted the feature/extra_oedversion_sources branch March 25, 2026 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sambles sambles sambles approved these changes

@benhayes21 benhayes21 benhayes21 approved these changes

Assignees

@SkylordA SkylordA

Labels

enhancement New feature or request feature A main feature, captured on the backlog

Projects

Oasis Dev Team Tasks
Status: Done

Milestone

2.5.0

Development

Successfully merging this pull request may close these issues.

Extra OED Version sources

4 participants

@SkylordA @sambles @benhayes21 @awsbuild