Skip to content

Feature Remove ktools#1836

Merged
sambles merged 80 commits intomainfrom
feature/rm-ktools
Feb 8, 2026
Merged

Feature Remove ktools#1836
sambles merged 80 commits intomainfrom
feature/rm-ktools

Conversation

@sambles
Copy link
Copy Markdown
Contributor

@sambles sambles commented Jan 16, 2026 •
edited
Loading

Refactored package and removed C++ binaries

  • Moved to using pyproject.toml over setup.py (and updated CI to match)
  • Dropped non-ORD outputs as options
  • Pytools is now the main kernel option, ktools binaries are not built into the package
  • Removed params that enabled pytools (now the only option)
  • Removed 'legacy_stream' option
  • Removed / Updated GenBash tests
  • renamed parameters, anything using ktools- is now kernel-, so from --ktools-alloc-rule-il to --kernel-alloc-rule-il

Manual Piwind checks

Linked to

Difference in ORD output when switching to all pytools for a piwind run fixed with #1859
defaults-run-ORD.zip
pytools-only-run-ORD.zip
update-pytools.zip - after fix

Manual Piwind check

CI failing because OasisLMF/OasisPlatform#1317 not released yet
https://github.com/OasisLMF/OasisPlatform/actions/runs/21796276874

https://github.com/OasisLMF/OasisPlatform/actions/runs/21796567591

@sambles sambles self-assigned this Jan 16, 2026
@sambles sambles linked an issue Jan 16, 2026 that may be closed by this pull request
Remove ktools binaries from python package #1828
Closed
@sambles sambles added the feature A main feature, captured on the backlog label Jan 16, 2026
@sambles sambles marked this pull request as draft January 16, 2026 10:28
@sambles sambles marked this pull request as ready for review February 4, 2026 08:55
@SkylordA SkylordA self-requested a review February 4, 2026 10:05
@sambles sambles requested a review from sstruzik February 4, 2026 10:06
SkylordA
SkylordA approved these changes Feb 5, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@SkylordA SkylordA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine
Reminder to also merge this into here first
#1859

sambles and others added 17 commits February 7, 2026 13:12
@sambles
example settings not used
63c4a0c
@sambles
rename monitor script and remove refs to older execs
89231b0
@sambles
clear older tool name
a9deaa8
@sambles
update compatibility_profile
888f3f6
@sambles
Update Ktools to kernel
b7c7ccf
@sambles
Update bash
3d23035
@sambles
find n replace ktools --> kernel
7cf6f35
@sambles
test fixes
a2d98f5
@sambles
Fix test again
2709d98
@sambles
hardcode to test
d93ae81
@sambles
Revert "hardcode to test"
3c1a7f2 
This reverts commit df94217.
@sambles
Revert "test piwind fixes"
7a57580 
This reverts commit dc40981.
@sambles
Revert "tmp pip pandas before 3 to check tests - revert later"
e5fa8ac 
This reverts commit a2f60a0.
@sambles
revert more testing hardcodes
5a7a29e
@sambles
raise any older settings output as errors
f9cf2b6
@SkylordA @sambles
fixes to output calc for selt, melt, qelt, mplt (#1859)
a2939b9 
* fixes to output calc for selt, melt, qelt, mplt

* updates summarypy order of sidxs starting from -5 to -1, updates tests files
@sambles
Fix support for oed-tools 4
2997e82
@sambles sambles mentioned this pull request Feb 7, 2026
Merged
@sambles sambles merged commit 65bd2c6 into main Feb 8, 2026
23 of 25 checks passed
@sambles sambles deleted the feature/rm-ktools branch February 8, 2026 11:52
@awsbuild awsbuild added this to the 2.5.0 milestone Feb 8, 2026
@dholdaway dholdaway mentioned this pull request Mar 23, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SkylordA SkylordA SkylordA approved these changes

@sstruzik sstruzik Awaiting requested review from sstruzik

Assignees

@sambles sambles

Labels

feature A main feature, captured on the backlog

Projects

Oasis Dev Team Tasks
Status: Done

Milestone

2.5.0

Development

Successfully merging this pull request may close these issues.

Remove ktools binaries from python package

3 participants

@sambles @SkylordA @awsbuild