Merged
Conversation
Ha-Ree
reviewed
Dec 16, 2025
Contributor
Ha-Ree
left a comment
Ha-Ree
left a comment
There was a problem hiding this comment.
Instead of doing it after every continue and at the end of the loop, would it not just be easier to call it once at the start and once after the loop ends?
This function definitely needs to be rewritten at some point in my opinion because attempting to understand a 500 line function that could easily be broken down into 10+ smaller easier to digest ones would make it significantly easier to debug and to review
Ha-Ree
approved these changes
Dec 16, 2025
Merged
vinulw
approved these changes
Dec 16, 2025
sambles
pushed a commit
that referenced
this pull request
Dec 16, 2025
* fix fm empty layer with account terms * add only account terms test case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix IL for ptf with empty Policy layer level and account terms
Fix an issue on the prev_agg_id used for account terms for portfolio with no Policy layer level.