Fixed merging analyses computation_settings on the platform#1813
Merged
Fixed merging analyses computation_settings on the platform#1813
Conversation
File "/home/worker/.local/lib/python3.12/site-packages/celery/app/trace.py", line 453, in trace_task
R = retval = fun(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^
File "/home/worker/.local/lib/python3.12/site-packages/celery/app/trace.py", line 736, in __protected_call__
return self.run(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/worker/.local/lib/python3.12/site-packages/celery/app/autoretry.py", line 60, in run
ret = task.retry(exc=exc, **retry_kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/worker/.local/lib/python3.12/site-packages/celery/app/task.py", line 743, in retry
raise_with_context(exc)
File "/home/worker/.local/lib/python3.12/site-packages/celery/app/autoretry.py", line 38, in run
return task._orig_run(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/worker/src/model_execution_worker/tasks.py", line 181, in run
return fn(self, analysis_pk, *args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/worker/src/model_execution_worker/tasks.py", line 435, in generate_input
gen_files_params = OasisManager()._params_generate_oasis_files(**lookup_params)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/worker/.local/lib/python3.12/site-packages/oasislmf/computation/base.py", line 147, in get_arguments
new_settings.pop("computation_settings", {}), {ROOT_USER_ROLE}
^^^^^^^^^^^^^^^^
TypeError: unhashable type: 'set'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/home/worker/.local/lib/python3.12/site-packages/celery/app/trace.py", line 453, in trace_task
R = retval = fun(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^
File "/home/worker/.local/lib/python3.12/site-packages/celery/app/trace.py", line 736, in __protected_call__
return self.run(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/worker/.local/lib/python3.12/site-packages/celery/app/autoretry.py", line 60, in run
ret = task.retry(exc=exc, **retry_kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/worker/.local/lib/python3.12/site-packages/celery/app/task.py", line 743, in retry
raise_with_context(exc)
File "/home/worker/.local/lib/python3.12/site-packages/celery/app/autoretry.py", line 38, in run
return task._orig_run(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/worker/src/model_execution_worker/tasks.py", line 181, in run
return fn(self, analysis_pk, *args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/worker/src/model_execution_worker/tasks.py", line 435, in generate_input
gen_files_params = OasisManager()._params_generate_oasis_files(**lookup_params)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/worker/.local/lib/python3.12/site-packages/oasislmf/computation/base.py", line 145, in get_arguments
new_settings = settings_info["loader"](setting_fp)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/worker/.local/lib/python3.12/site-packages/ods_tools/oed/settings.py", line 384, in load
raise OdsException(f'Invalid {self.settings_type} file or file path: {settings_fp}')
ods_tools.oed.common.OdsException: Invalid model_settings file or file path: meta-data/model_settings.json
This was referenced Dec 4, 2025
Ha-Ree
approved these changes
Dec 12, 2025
sstruzik
approved these changes
Dec 16, 2025
sambles
added a commit
that referenced
this pull request
Dec 16, 2025
* Add param settings merging into the kwarg func called by the platform
* pep
* fix error in plat
File "/home/worker/.local/lib/python3.12/site-packages/celery/app/trace.py", line 453, in trace_task
R = retval = fun(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^
File "/home/worker/.local/lib/python3.12/site-packages/celery/app/trace.py", line 736, in __protected_call__
return self.run(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/worker/.local/lib/python3.12/site-packages/celery/app/autoretry.py", line 60, in run
ret = task.retry(exc=exc, **retry_kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/worker/.local/lib/python3.12/site-packages/celery/app/task.py", line 743, in retry
raise_with_context(exc)
File "/home/worker/.local/lib/python3.12/site-packages/celery/app/autoretry.py", line 38, in run
return task._orig_run(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/worker/src/model_execution_worker/tasks.py", line 181, in run
return fn(self, analysis_pk, *args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/worker/src/model_execution_worker/tasks.py", line 435, in generate_input
gen_files_params = OasisManager()._params_generate_oasis_files(**lookup_params)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/worker/.local/lib/python3.12/site-packages/oasislmf/computation/base.py", line 147, in get_arguments
new_settings.pop("computation_settings", {}), {ROOT_USER_ROLE}
^^^^^^^^^^^^^^^^
TypeError: unhashable type: 'set'
* Fix loading default fp thats not set
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/home/worker/.local/lib/python3.12/site-packages/celery/app/trace.py", line 453, in trace_task
R = retval = fun(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^
File "/home/worker/.local/lib/python3.12/site-packages/celery/app/trace.py", line 736, in __protected_call__
return self.run(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/worker/.local/lib/python3.12/site-packages/celery/app/autoretry.py", line 60, in run
ret = task.retry(exc=exc, **retry_kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/worker/.local/lib/python3.12/site-packages/celery/app/task.py", line 743, in retry
raise_with_context(exc)
File "/home/worker/.local/lib/python3.12/site-packages/celery/app/autoretry.py", line 38, in run
return task._orig_run(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/worker/src/model_execution_worker/tasks.py", line 181, in run
return fn(self, analysis_pk, *args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/worker/src/model_execution_worker/tasks.py", line 435, in generate_input
gen_files_params = OasisManager()._params_generate_oasis_files(**lookup_params)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/worker/.local/lib/python3.12/site-packages/oasislmf/computation/base.py", line 145, in get_arguments
new_settings = settings_info["loader"](setting_fp)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/worker/.local/lib/python3.12/site-packages/ods_tools/oed/settings.py", line 384, in load
raise OdsException(f'Invalid {self.settings_type} file or file path: {settings_fp}')
ods_tools.oed.common.OdsException: Invalid model_settings file or file path: meta-data/model_settings.json
* f
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed merging analyses computation_settings on the platform
The computation_settings sections in analyses and model settings are not pickup and merged by the platform.
Fixed so it works the same way as MDK