Skip to content

fix/platform_login#1812

Merged
sambles merged 2 commits intomainfrom
fix/platform_login
Jan 7, 2026
Merged

fix/platform_login#1812
sambles merged 2 commits intomainfrom
fix/platform_login

Conversation

@SkylordA
Copy link
Copy Markdown
Contributor

@SkylordA SkylordA commented Dec 4, 2025

fix/platform_login

change platformbase login logic and debug messages for failed login attempts
closes #1809

@SkylordA SkylordA self-assigned this Dec 4, 2025
@SkylordA SkylordA added the enhancement New feature or request label Dec 4, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 4, 2025

Codecov Report

❌ Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.25%. Comparing base (195aa8d) to head (880e5c7).
⚠️ Report is 23 commits behind head on main.

Files with missing lines Patch % Lines
oasislmf/computation/run/platform.py 75.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1812      +/-   ##
==========================================
- Coverage   74.40%   74.25%   -0.15%     
==========================================
  Files         232      232              
  Lines       19000    19114     +114     
==========================================
+ Hits        14136    14193      +57     
- Misses       4864     4921      +57     
Files with missing lines Coverage Δ
oasislmf/computation/run/platform.py 95.35% <75.00%> (-4.65%) ⬇️

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1786e72...880e5c7. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@SkylordA SkylordA requested review from sambles and vinulw and removed request for vinulw December 17, 2025 11:25
Copy link
Copy Markdown
Contributor

@vinulw vinulw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 lgtm

@sambles sambles merged commit a985b10 into main Jan 7, 2026
26 checks passed
@sambles sambles deleted the fix/platform_login branch January 7, 2026 12:01
@awsbuild awsbuild added this to the 2.5.0 milestone Feb 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Improve PlatformBase login flow and debug messages

4 participants