Skip to content

lookup build_merge can read other pd-allowed filetypes#1802

Merged
Ha-Ree merged 2 commits intomainfrom
enhancement/merge_read_pandas
Nov 26, 2025
Merged

lookup build_merge can read other pd-allowed filetypes#1802
Ha-Ree merged 2 commits intomainfrom
enhancement/merge_read_pandas

Conversation

@Ha-Ree
Copy link
Copy Markdown
Contributor

@Ha-Ree Ha-Ree commented Nov 25, 2025

Allows other non-csv file types to be read

@Ha-Ree Ha-Ree linked an issue Nov 25, 2025 that may be closed by this pull request
@Ha-Ree Ha-Ree requested review from sstruzik and vinulw November 25, 2025 16:32
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.34%. Comparing base (195aa8d) to head (ec3d64e).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1802      +/-   ##
==========================================
- Coverage   74.40%   74.34%   -0.06%     
==========================================
  Files         232      232              
  Lines       19000    19001       +1     
==========================================
- Hits        14136    14127       -9     
- Misses       4864     4874      +10     
Files with missing lines Coverage Δ
oasislmf/lookup/builtin.py 72.14% <100.00%> (+0.17%) ⬆️

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acfe206...ec3d64e. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sambles sambles mentioned this pull request Nov 26, 2025
1 task
Copy link
Copy Markdown
Contributor

@vinulw vinulw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍🏾

@Ha-Ree Ha-Ree merged commit 632b154 into main Nov 26, 2025
28 checks passed
@Ha-Ree Ha-Ree deleted the enhancement/merge_read_pandas branch November 26, 2025 16:00
@awsbuild awsbuild added this to the 2.4.10 milestone Nov 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Build_merge accepts only csv arguments

4 participants