Conversation
…nt_credentials for service authentication.
…thentication, as these do not return a refresh_token and require calling access_token again directly
… avoid recursive loop and corrects false call to refresh_token
… tokens directly. Adds default credentials as before to allow PiWind tests to run
* remove package pin for piwind checks * back to simple
sambles
approved these changes
Nov 18, 2025
vinulw
approved these changes
Nov 18, 2025
| return json.load(f) | ||
|
|
||
| while True: | ||
| user_response = input("Use simple JWT [Y/n]: ").lower().strip() |
Contributor
There was a problem hiding this comment.
JWT acronym might be confusing. I think we can remove and always refer to the username password authentication as the "simple" flow for authentication.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feature/generic_oidc
Updates the PlatformBase class and APIClient/Session to support username/password login for simple JWT, and client_id/client_credentials for OIDC to authenticate services