Skip to content

fix simple step policies#1776

Merged
sambles merged 5 commits intorelease/2.3.19from
fix/single_step_policy
Nov 7, 2025
Merged

fix simple step policies#1776
sambles merged 5 commits intorelease/2.3.19from
fix/single_step_policy

Conversation

@sstruzik
Copy link
Copy Markdown
Contributor

@sstruzik sstruzik commented Oct 7, 2025

fix simple step policies

Fix an issue in need_account_aggregation step that remove step id from the aggregation key thus removing step policies.

@sstruzik sstruzik self-assigned this Oct 7, 2025
@sstruzik sstruzik added bug Something isn't working LTS - 2.3 LTS - 2.4 labels Oct 7, 2025
@sstruzik sstruzik requested a review from benhayes21 October 31, 2025 09:33
@sstruzik sstruzik requested a review from vinulw October 31, 2025 09:37
@sstruzik sstruzik changed the base branch from main to stable/2.3.x October 31, 2025 09:38
@sstruzik sstruzik changed the base branch from stable/2.3.x to main October 31, 2025 09:40
@sstruzik sstruzik marked this pull request as draft October 31, 2025 09:46
@sstruzik sstruzik changed the base branch from main to stable/2.3.x October 31, 2025 09:52
@sstruzik sstruzik force-pushed the fix/single_step_policy branch from a08830a to ea0b8ae Compare October 31, 2025 10:46
@sstruzik sstruzik marked this pull request as ready for review November 3, 2025 10:03
@sstruzik sstruzik requested review from Ha-Ree and benhayes21 November 5, 2025 11:08
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 7, 2025

Codecov Report

❌ Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.80%. Comparing base (f80d649) to head (ec81919).
⚠️ Report is 14 commits behind head on stable/2.3.x.

Files with missing lines Patch % Lines
oasislmf/preparation/il_inputs.py 20.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           stable/2.3.x    #1776       +/-   ##
=================================================
- Coverage         82.25%   71.80%   -10.45%     
=================================================
  Files               117      117               
  Lines             13190    13220       +30     
=================================================
- Hits              10849     9493     -1356     
- Misses             2341     3727     +1386     
Files with missing lines Coverage Δ
oasislmf/preparation/il_inputs.py 91.90% <20.00%> (-0.18%) ⬇️

... and 20 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86b4611...ec81919. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sambles sambles changed the base branch from stable/2.3.x to release/2.3.19 November 7, 2025 11:45
@sambles sambles merged commit 83e767a into release/2.3.19 Nov 7, 2025
31 of 32 checks passed
@sambles sambles deleted the fix/single_step_policy branch November 7, 2025 11:46
@sambles sambles mentioned this pull request Nov 7, 2025
@awsbuild awsbuild added this to the 2.3.19 milestone Nov 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working LTS - 2.3

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants