bypass amplification.bin load in pla when uniform factor is provided#1756
Merged
bypass amplification.bin load in pla when uniform factor is provided#1756
Conversation
SkylordA
approved these changes
Aug 26, 2025
benhayes21
approved these changes
Aug 27, 2025
github-project-automation
bot
moved this from Waiting for Review
to Done
in Oasis Dev Team Tasks
Merged
sambles
pushed a commit
that referenced
this pull request
Nov 7, 2025
…1756) * bypass amplification.bin load in pla when uniform factor is provided
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bypass amplification.bin load in post loss amplification when uniform factor is provided
When a uniform factor is provided, amplification.bin load is not needed. This PR remove this step and allow user to provide a uniform factor without the need to create the amplification.bin file