Skip to content

Progress bar#1747

Merged
sstruzik merged 43 commits intomainfrom
clean_progress
Sep 24, 2025
Merged

Progress bar#1747
sstruzik merged 43 commits intomainfrom
clean_progress

Conversation

@Ha-Ree
Copy link
Copy Markdown
Contributor

@Ha-Ree Ha-Ree commented Jul 30, 2025

See #1739
Goes with OasisLMF/OasisPlatform#1242
Adds a oasis-ping command and calls for it from the bash script generation to send the platform information on gul event completion
Adds a tqdm progress bar for v1 in the same fashion as v2 based on the websocket pings

@Ha-Ree Ha-Ree removed request for sstruzik and vinulw August 22, 2025 13:44
@Ha-Ree Ha-Ree requested review from sstruzik and vinulw and removed request for sstruzik September 10, 2025 10:19
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 19, 2025

Codecov Report

❌ Patch coverage is 81.15942% with 39 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.40%. Comparing base (ffd1023) to head (879341b).
⚠️ Report is 47 commits behind head on main.

Files with missing lines Patch % Lines
oasislmf/utils/socket_server.py 78.12% 14 Missing ⚠️
oasislmf/computation/generate/losses.py 57.14% 9 Missing ⚠️
oasislmf/pytools/getmodel/manager.py 20.00% 4 Missing ⚠️
oasislmf/pytools/gul/manager.py 66.66% 4 Missing ⚠️
oasislmf/execution/bash.py 88.88% 2 Missing ⚠️
oasislmf/pytools/gulmc/cli.py 0.00% 2 Missing ⚠️
oasislmf/pytools/gulpy.py 0.00% 2 Missing ⚠️
oasislmf/pytools/gulmc/manager.py 90.90% 1 Missing ⚠️
oasislmf/pytools/modelpy.py 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1747      +/-   ##
==========================================
- Coverage   82.16%   74.40%   -7.76%     
==========================================
  Files         150      229      +79     
  Lines       16252    18855    +2603     
==========================================
+ Hits        13354    14030     +676     
- Misses       2898     4825    +1927     
Files with missing lines Coverage Δ
oasislmf/computation/run/model.py 85.41% <100.00%> (-0.86%) ⬇️
oasislmf/platform_api/client.py 94.55% <100.00%> (-4.47%) ⬇️
oasislmf/utils/defaults.py 84.00% <100.00%> (+0.49%) ⬆️
oasislmf/utils/ping.py 100.00% <100.00%> (ø)
oasislmf/pytools/gulmc/manager.py 85.18% <90.90%> (-2.08%) ⬇️
oasislmf/pytools/modelpy.py 0.00% <0.00%> (-96.00%) ⬇️
oasislmf/execution/bash.py 89.23% <88.88%> (+0.17%) ⬆️
oasislmf/pytools/gulmc/cli.py 0.00% <0.00%> (-97.15%) ⬇️
oasislmf/pytools/gulpy.py 0.00% <0.00%> (-96.56%) ⬇️
oasislmf/pytools/getmodel/manager.py 53.40% <20.00%> (-31.83%) ⬇️
... and 3 more

... and 27 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c7a41b...879341b. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sstruzik sstruzik merged commit 3467203 into main Sep 24, 2025
26 checks passed
@Ha-Ree Ha-Ree deleted the clean_progress branch September 24, 2025 14:25
@sambles sambles mentioned this pull request Sep 25, 2025
@awsbuild awsbuild added this to the 2.4.8 milestone Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants