Skip to content

[Feature] Added Pagination in webUI #818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
securestep9 merged 2 commits into from
Mar 6, 2024
Merged

[Feature] Added Pagination in webUI #818

securestep9 merged 2 commits into from
Mar 6, 2024

Conversation

@Freedisch
Copy link
Contributor

@Freedisch Freedisch commented Mar 3, 2024

Checklist

  • I have followed the Contributor Guidelines.
  • The code has been thoroughly tested in my local development environment with flake8 and pylint.
  • The code is Python 3 compatible.
  • The code follows the PEP8 styling guidelines with 4 spaces indentation.
  • This Pull Request relates to only one issue or only one feature
  • I have referenced the corresponding issue number in my commit message
  • I have added the relevant documentation.
  • My branch is up-to-date with the Upstream master branch.

Changes proposed in this pull request

This PR fixes issue #805 added pagination to web UI for both Crawler and Results page

Screen.Recording.2024-03-03.at.19.13.28.mov

Your development environment

  • OS: x
  • OS Version: x
  • Python Version: x

@securestep9
Copy link
Collaborator

securestep9 commented Mar 3, 2024

Thank you for your contribution. In our example you only have 5 pages, however have you tested your solution in situations when results contain lots of pages (for example 50 or 500) taking the entire width of the screen? what happens in that case?

@Freedisch
Copy link
Contributor Author

Freedisch commented Mar 4, 2024 •
edited
Loading

@securestep9, Depending on the total number of page, but When we have more than 4 pages only 4 buttons will be always displayed and updated. If we are at the 49th element, the numbers will be displayed like the following 47 48 49 50
Screenshot 2024-03-04 at 16 17 11

Screenshot 2024-03-04 at 16 17 03

@securestep9 securestep9 self-requested a review March 6, 2024 22:17
@securestep9 securestep9 self-assigned this Mar 6, 2024
@securestep9 securestep9 added enhancement UI update For the isuues and pull request with UI updates labels Mar 6, 2024
@securestep9 securestep9 linked an issue Mar 6, 2024 that may be closed by this pull request
pagination feature needed in WebUI Results and Crawler search results #805
Closed
@securestep9 securestep9 merged commit ff0900d into OWASP:master Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@securestep9 securestep9 securestep9 approved these changes

Assignees

@securestep9 securestep9

Labels

enhancement UI update For the isuues and pull request with UI updates

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

pagination feature needed in WebUI Results and Crawler search results

2 participants

@Freedisch @securestep9