Detecting open Dropbear server #808
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arkid15r
reviewed
Feb 8, 2024
Collaborator
arkid15r
left a comment
arkid15r
left a comment
There was a problem hiding this comment.
@Captain-T2004 thanks for digging into this!
I wonder how it worked without the explicit empty password in top 1000 common passwords file.
Please find my suggestion on possible code improvement below. This code needs to be tested for the Dropbear case.
Thank you!
arkid15r
reviewed
Feb 12, 2024
Collaborator
arkid15r
left a comment
arkid15r
left a comment
There was a problem hiding this comment.
Hey @Captain-T2004, thanks for the fix!
Here is my another suggestion that needs to be verified:
arkid15r
reviewed
Feb 13, 2024
Collaborator
arkid15r
left a comment
arkid15r
left a comment
There was a problem hiding this comment.
You can make it more compact (see the suggestion). Otherwise LGTM, great work!
After testing it rigorously i have found that without the try and except the code doesn't work, so to improve the readability i have added some comments, also added is finally block to close the connection.
As per the suggestions i have replaced try/except with if/else and i have ran multiple tests on my localhost to test and it is working.
I have made the suggested changes to the code to make it more concise and easy to read. I have taken time to test it and make sure it works( it does ).
arkid15r
approved these changes
Mar 11, 2024
Collaborator
arkid15r
left a comment
arkid15r
left a comment
There was a problem hiding this comment.
I've tested the PR, it works (Dropbear v2022.83). I'm merging this.
Thanks everyone!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Changes proposed in this pull request
This pull request solves issue #715,
Due to internal workings of Paramiko library used to connect to SSH in core_ssh.py, Nettacker was unable to detect an open passwordless SSH server. Adding an exception fixes that problem. But to be on the safe side i have added an empty line to the default passwords list(Nettacker/lib/payloads/passwords/top_1000_common_passwords.txt).
Your development environment
Pop-OS22.043.10