Skip to content

l10n: sync missing Russian locale messages - #1659

Merged
securestep9 merged 1 commit into
OWASP:masterfrom
srkyn:l10n/russian-locale-sync
Aug 10, 2026
Merged

l10n: sync missing Russian locale messages#1659
securestep9 merged 1 commit into
OWASP:masterfrom
srkyn:l10n/russian-locale-sync

Conversation

@srkyn

@srkyn srkyn commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Proposed change

Adds Russian translations for the 59 messages that are present in en.yaml but missing from ru.yaml. This restores key parity between the two locale files. I reviewed every added string in context and preserved the existing format placeholders.

Fixes #1655

Validation

Validated from a clean Docker checkout with Python 3.11.15:

  • make pre-commit: all 8 hooks passed with no changes.
  • make test: 340 passed, 6 skipped, and 2 xfailed in 26.20 seconds.
  • Both locale files parse as valid YAML.
  • Russian and English locale keys match.
  • Format placeholders match for all 59 added messages.

Type of change

  • New core framework functionality
  • Bugfix (non-breaking change that fixes an issue)
  • Code refactoring without any functionality changes
  • New or existing module/payload change
  • Documentation/localization improvement
  • Test coverage improvement
  • Dependency upgrade
  • Other improvement (best practice, cleanup, optimization, etc)

Checklist

  • I've followed the contributing guidelines
  • I've digitally signed all my commits in this PR
  • I've run make pre-commit and confirm it didn't generate any warnings/changes
  • I've run make test and I confirm all tests passed locally
  • I've added/updated any relevant documentation in the docs/ folder (not applicable for this locale-only change)
  • I've linked this PR with an open issue
  • I've tested and verified that my code works as intended and resolves the issue as described
  • I've attached screenshots demonstrating that my code works as intended (if applicable) (not applicable for this locale-only change)
  • I've checked all other open PRs to avoid submitting duplicate work
  • I confirm that the code and comments in this PR are not direct unreviewed outputs of AI
  • I confirm that I am the Sole Responsible Author for every line of code, comment, and design decision

@coderabbitai

coderabbitai Bot commented Aug 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: d3dffe37-6ea6-452c-8cd3-0e742d695ad3

📥 Commits

Reviewing files that changed from the base of the PR and between 834c9ce and 0cb343a.

📒 Files selected for processing (1)
  • nettacker/locale/ru.yaml

Summary by CodeRabbit

  • New Features
    • Added Russian translations for API certificates, service discovery, scan controls, HTTP options, reporting, profiles, hardware usage, and database operations.
    • Added localized messages for ICMP requirements, file and database errors, WHATCMS status, and module execution events.

Walkthrough

The Russian locale adds 59 missing messages covering API operations, module execution, scan controls, reporting, database operations, and related errors.

Changes

Russian locale synchronization

Layer / File(s) Summary
Runtime and API messages
nettacker/locale/ru.yaml		 Adds Russian messages for API certificates, service discovery, permissions, connectivity, module execution, loading failures, and hardware configuration.
Scan and reporting messages
nettacker/locale/ru.yaml		 Adds Russian messages for module and profile listings, scan lifecycle events, validation, HTTP options, wordlists, and report or database errors.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: arkid15r, securestep9

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the Russian locale synchronization and matches the primary change.
Description check ✅ Passed The description directly explains the added Russian translations, key parity, placeholder preservation, and validation results.
Linked Issues check ✅ Passed The PR adds the 59 missing Russian locale keys and reports preserved placeholders, native translations, unchanged existing entries, and completed checks for issue #1655.
Out of Scope Changes check ✅ Passed The changes are limited to the Russian locale file and align with the linked issue objectives.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@securestep9
securestep9 enabled auto-merge August 10, 2026 19:49
@securestep9
securestep9 added this pull request to the merge queue Aug 10, 2026
Merged via the queue into OWASP:master with commit 35c75df Aug 10, 2026
19 checks passed
@securestep9

securestep9 commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator

Thank you for your contribution @srkyn ! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@securestep9 securestep9 securestep9 approved these changes
@arkid15r arkid15r Awaiting requested review from arkid15r arkid15r is a code owner

Assignees

No one assigned

Labels

documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

l10n: sync missing Russian locale messages

2 participants

@srkyn @securestep9