FEAT: add link to OSSPH logo#54
Merged
jofftiquez merged 2 commits intoOSSPhilippines:mainfrom Jan 9, 2023
Merged
Conversation
jofftiquez
requested changes
Jan 9, 2023
index.html
Outdated
| <header class="bg-violet-500"> | ||
| <div class="container mx-auto px-5 py-8 flex flex-row justify-between"> | ||
| <img class="h-14" src="./images/osslogo-text-white.png" alt=""> | ||
| <a href="https://ossph.org/" target="_blank"><img class="h-14" src="./images/osslogo-text-white.png" alt=""></a> |
Member
There was a problem hiding this comment.
Hi, all good. I just have one last request. Please add "OSSPH Logo" as alt in the image. Thanks.
Contributor
Author
There was a problem hiding this comment.
Done. Kindly please review it, Thank you.
Member
|
Thank you for this @AbbeyIT. Just one last request in the comments. Thank you <3 |
Contributor
Author
|
Thank you @jofftiquez |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Issue #53
Details
On the homepage of Freefolio, I added the OSSPH link in the logo.